docs: fix REPL examples in blas/ext/base/zcartesian-square - #13668
Closed
Planeshifter wants to merge 2 commits into
Closed
docs: fix REPL examples in blas/ext/base/zcartesian-square#13668Planeshifter wants to merge 2 commits into
blas/ext/base/zcartesian-square#13668Planeshifter wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018Rjd5jgubG8sWSpMYaq7wJ
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
…square` Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018Rjd5jgubG8sWSpMYaq7wJ
kgryte
requested changes
Jul 26, 2026
kgryte
left a comment
Member
There was a problem hiding this comment.
The reason the example is the way it is is to avoid REPL lint errors and there isn't a good way of doing so atm. The changes in this PR are not desired. Closing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-07-26 02:12 (-0500) (0239983) and 2026-07-26 15:02 (+0500) (a7865fd).This pull request:
blas/ext/base/zcartesian-square: Fixed the REPL examples indocs/repl.txtforzcartesian-square(a7865fd): they used[ 1.0, 2.0 ], a single complex number, so N=1 and none of the stride/offset examples actually strided or offset anything. Replaced with two-element inputs matching the README's[ 1.0, 2.0, 3.0, 4.0 ]convention, with expected outputs corrected accordingly.Related Issues
No.
Questions
No.
Other
Validation. All commits merged to
developin the review window (0239983,4588717,d98aba7,01a20c0,b062197,651f410,a7865fd) were audited for stdlib style-guide compliance (compared againstdocs/style-guidesand established reference packages, e.g.dcartesian-square,dlacpy) and scanned for bugs (stride/offset arithmetic, loop bounds, test expectations, C sources, and native bindings were hand-verified). Only objective, independently re-verified issues are included; subjective concerns, style preferences not required by the style guide, and anything requiring changes outside the review window's diff were deliberately excluded. The expected outputs in the fixed examples mirror the package's own README, which was adapted correctly in the originating commit.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of an automated review of recently merged commits; the documentation fix was generated and verified by Claude Code.
Generated by Claude Code