Skip to content

docs: fix REPL examples in blas/ext/base/zcartesian-square - #13668

Closed
Planeshifter wants to merge 2 commits into
developfrom
philipp/fix-commit-review-2026-07-26
Closed

docs: fix REPL examples in blas/ext/base/zcartesian-square#13668
Planeshifter wants to merge 2 commits into
developfrom
philipp/fix-commit-review-2026-07-26

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

Follow-up fixes for commits merged to develop between 2026-07-26 02:12 (-0500) (0239983) and 2026-07-26 15:02 (+0500) (a7865fd).

This pull request:

  • blas/ext/base/zcartesian-square: Fixed the REPL examples in docs/repl.txt for zcartesian-square (a7865fd): they used [ 1.0, 2.0 ], a single complex number, so N=1 and none of the stride/offset examples actually strided or offset anything. Replaced with two-element inputs matching the README's [ 1.0, 2.0, 3.0, 4.0 ] convention, with expected outputs corrected accordingly.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation. All commits merged to develop in the review window (0239983, 4588717, d98aba7, 01a20c0, b062197, 651f410, a7865fd) were audited for stdlib style-guide compliance (compared against docs/style-guides and established reference packages, e.g. dcartesian-square, dlacpy) and scanned for bugs (stride/offset arithmetic, loop bounds, test expectations, C sources, and native bindings were hand-verified). Only objective, independently re-verified issues are included; subjective concerns, style preferences not required by the style guide, and anything requiring changes outside the review window's diff were deliberately excluded. The expected outputs in the fixed examples mirror the package's own README, which was adapted correctly in the originating commit.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by Claude Code as part of an automated review of recently merged commits; the documentation fix was generated and verified by Claude Code.



Generated by Claude Code

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Jul 26, 2026
@stdlib-bot

stdlib-bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/zcartesian-square $\\color{green}492/492$
$\\color{green}+0.00\\%$
$\\color{green}39/39$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}492/492$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason the example is the way it is is to avoid REPL lint errors and there isn't a good way of doing so atm. The changes in this PR are not desired. Closing.

@kgryte kgryte closed this Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants