Skip to content

test: migrate math/base/special/sqrtpif to ULP-based testing - #13803

Merged
kgryte merged 1 commit into
stdlib-js:developfrom
ujjwalv01:test-sqrtpif-ulp
Jul 31, 2026
Merged

test: migrate math/base/special/sqrtpif to ULP-based testing#13803
kgryte merged 1 commit into
stdlib-js:developfrom
ujjwalv01:test-sqrtpif-ulp

Conversation

@ujjwalv01

Copy link
Copy Markdown
Contributor

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • Migrates the tests for @stdlib/math/base/special/sqrtpif to use precise ULP-based bounds for floating-point comparisons rather than relative epsilon tolerances.
  • Replaces absolute differences and epsilon logic with @stdlib/number/float32/base/assert/is-almost-same-value.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

@ujjwalv01
ujjwalv01 requested a review from a team July 31, 2026 13:08
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Jul 31, 2026
@stdlib-bot

stdlib-bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/sqrtpif $\\color{green}169/169$
$\\color{green}+0.00\\%$
$\\color{green}5/5$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}169/169$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added Tests Pull requests specifically adding tests. review: 5 and removed Needs Review A pull request which needs code review. labels Jul 31, 2026

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte
kgryte merged commit 351f7c0 into stdlib-js:develop Jul 31, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. review: 5 Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants