test: migrate stats/incr/nanmprod to ULP-based assertions - #15140
Draft
kgryte wants to merge 1 commit into
Draft
Conversation
Migrate the two relative-tolerance assertion sites in the tests for `stats/incr/nanmprod` to ULP-difference assertions using `@stdlib/assert/is-almost-same-value`. Both sites require a minimum bound of 1 ULP. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019Fdzvd3XioK2mzPYas59Hf --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/incr/nanmprodfrom computed relative-tolerance comparisons (delta = abs( expected - acc() )/tol = EPSILON * abs( expected ), asserted viat.strictEqual( delta <= tol, ... )) to ULP-difference assertions using@stdlib/assert/is-almost-same-value.test/test.js(theoverflow may be transientandunderflow may be transienttests). The package has notest/test.native.js, and the remaining assertions in the file are exact comparisons againstnull,NaN,+-infinity, signed zeros, and exactly representable values, which are correct as-is and are left unchanged.@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires, along with thedeltaandtolvariable declarations, introducing anactualvariable at each site to match the migrated idiom used elsewhere instats/incr.Only a test file is changed; no implementation, fixture, or documentation changes are included.
ULP bounds
EPSILON * abs( expected )1EPSILON * abs( expected )1These are the minimum integer bounds
Nsuch thatisAlmostSameValue( actual, expected, N )holds at each site. They were measured independently of the test harness by driving the accumulator directly and searching upward from0for the smallest bound satisfied at each site, starting from a high bound (64, which passes) and tightening:1.0715086071862675e+299against an expected value ofldexp( 0.01, 1000 )=1.0715086071862673e+299, a difference of exactly1ULP.9.33263618503219e-304against an expected value ofldexp( 0.01, -1000 )=9.332636185032189e-304, a difference of exactly1ULP.Tightening either site by one ULP was verified to fail: at
N = 0, 2 of 483 assertions fail (one per site), confirming both bounds are minimal rather than merely sufficient. Both sites are fully deterministic — they use fixedldexpinputs with no random data.make test TESTS_FILTER=".*/stats/incr/nanmprod/.*"was run twice at the final bounds with identical results: 483/483 passing on both runs, no failures, ruling out FMA/architecture-dependent flakiness on this platform.make eslint-tests TESTS_FILTER=".*/stats/incr/nanmprod/.*"is clean.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
The resulting diff mirrors the already-merged migrations for the sibling packages
stats/incr/nanmhmean(#15125) andstats/incr/nanmstdev(#15072), which have the same accumulator test structure.One environment note, which did not affect verification:
make install-node-modulesinitially failed withETARGETfores-object-atoms@^1.1.2. As previously observed in #15116 and #15125, this is a stale local npm packument cache rather than a repository or registry problem (the registry does serve1.1.2);npm cache clean --forcefollowed bymake install-node-modulesandmake initsucceeded, and the full toolchain was available for this PR. Separately, thelint-editorconfig-filespre-commit step could not download theeditorconfig-checkerbinary in this sandbox and was skipped viaSKIP_LINT_EDITORCONFIG; the changed lines were checked manually for LF line endings, tab indentation, no trailing whitespace, and a final newline. All other pre-commit lint steps ran normally.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, running as an unattended scheduled task. It selected the package, studied previously migrated packages in the same family to match the established idiom, performed the migration, and determined the minimum passing ULP bound empirically at each assertion site.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_019Fdzvd3XioK2mzPYas59Hf
Generated by Claude Code