fix: restore math/base/special tests and remove duplicated REPL text - #15237
Draft
Planeshifter wants to merge 3 commits into
Draft
Planeshifter wants to merge 3 commits into
Planeshifter wants to merge 3 commits into
Conversation
The test file for the `math/base/special` namespace package was accidentally removed when scaffolding `math/base/special/tanhf` (see 5258215), leaving the namespace package without tests and with a dangling `directories.test` entry. This commit restores the file as it existed prior to removal. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ApgqTYLbBALZcimF9KJqM5
…mpose` An incomplete find-and-replace in a697555 added updated description lines to the REPL help text without removing the originals, resulting in duplicated, garbled text. This commit removes the stale lines. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ApgqTYLbBALZcimF9KJqM5
The restored test file is a new file from git's perspective, so the copyright notice must reference the current year per the copyright year lint check. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ApgqTYLbBALZcimF9KJqM5
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
Follow-up fixes for commits merged to
developbetween 2026-09-14T16:19:57-07:00 (adb952a) and 2026-09-15T02:37:51-07:00 (c24d71e).math/base/special: Fix:5258215e0clobberedlib/node_modules/@stdlib/math/base/special/test/test.jswhen addingtanhf, git recording the new package'slib/index.jsas a rename of it and leavingdirectories.testinpackage.jsonpointing at nothing. Restored the test file verbatim from the parent commit.fft/base/fftpack/float32/decompose: Fixes a doc bug froma697555: the refactor offft/base/fftpack/float32/decomposerewrote two description lines inlib/node_modules/@stdlib/fft/base/fftpack/float32/decompose/docs/repl.txtto backtickNbut left the original two in place, duplicating the paragraph in the REPL help. Removes the stale pair.Related Issues
No.
Questions
No.
Other
Validation
All 43 commits merged to
developin the review window were audited for style guide compliance (againstdocs/style-guidesand established reference packages) and scanned for bugs (diff-scoped logic, values, and documentation checks; the newtanhfimplementation was executed against its Python-generated fixtures in both JS and C, and the newblas/ext/base/glast-index-greater-than-equalexamples were hand-evaluated). Only objective, independently re-verified defects were fixed; anything requiring interpretation, judgment calls, or changes outside the window's diff was deliberately excluded. Notably excluded:fft/base/fftpack/float32/rfftistill passingFloat32Arrayworkspaces to the refactoreddecompose— behavior is unchanged and a change would fall outside the reviewed diff.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was produced by a scheduled Claude Code review of the last 24 hours of commits merged to
develop; the fixes were authored and validated by Claude Code.🤖 Generated with Claude Code
https://claude.ai/code/session_01ApgqTYLbBALZcimF9KJqM5
Generated by Claude Code