fix(api): fail closed when session is nil during user update (fixes #2665) - #2709
Open
deepshekhardas wants to merge 1 commit into
Open
fix(api): fail closed when session is nil during user update (fixes #2665)#2709deepshekhardas wants to merge 1 commit into
deepshekhardas wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(api): fail closed when session is nil during user update (fixes #2665)
A
customize_access_tokenhook that blankssession_idproduces atoken whose session never loads, leaving
session == nilinUserUpdate.MinimumViableTokenSchemaonly checkssession_idis a string, so""and the nil UUID pass, and
maybeLoadUserOrSessionskips loading thesession for those values.
user.HasMFAEnabled() && !session.IsAAL2()and!session.IsRecovery()then panic on the nil receiver, surfacing as a 500 via
recoverer.Fail closed, matching
requirePasskeyManagementAALand the existingsession == nilguards at lines 154/206:(401
insufficient_aal).(400
current_password_required).The obvious alternative — skipping the checks on nil — would let a
hook-blanked token change a password with no AAL2 and no current
password, so the guards must not be bypassed.