Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ai-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ jobs:
# its output file — the step sits idle until the job timeout, discarding
# a completed review (openai/codex-action#150). v1.11 handles the same
# heavy workload cleanly. There is no released fix above v1.12 yet.
uses: openai/codex-action@52fe01ec70a42f454c9d2ebd47598f9fd6893d56 # v1.11
uses: openai/codex-action@86365089eb2b84e0a8fb0717b304f8bdcb13b20e # v1.12

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the Codex action pinned below v1.12

Revert this pin to v1.11 until the documented regression is fixed. As the immediately preceding workflow comment records from openai/codex-action#150, v1.12 can hang after completing a heavy Linux run and writing its output, so this step waits until the 45-minute job timeout and discards a completed review. The same v1.12 pin is also introduced in the adjudication job, allowing either stage to prevent the AI review from being posted.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Severity: MEDIUM

Pinning v1.12 here reintroduces the known Linux completion failure documented in openai/codex-action#150. For sufficiently heavy reviews, Codex writes its output but never exits; this step then times out before validation/artifact upload, so adjudication loses this independent security review.
Helpful? Add 👍 / 👎

💡 Fix Suggestion

Suggestion: Revert the openai/codex-action pin on line 328 back to the v1.11 commit hash (52fe01ec70a42f454c9d2ebd47598f9fd6893d56). The inline comment block at lines 323–327 already documents why v1.12 must not be used: it introduces a confirmed regression (openai/codex-action#150) where a heavy Linux run never exits after Codex writes its output, causing the step to sit idle until the job timeout and losing the completed review. The surrounding comment block's text (# Pinned to v1.11, NOT v1.12) should also be preserved as-is — no change needed there. Only the uses: line itself needs to be reverted.

⚠️ Experimental Feature: This code suggestion is automatically generated. Please review carefully.

Suggested change
uses: openai/codex-action@86365089eb2b84e0a8fb0717b304f8bdcb13b20e # v1.12
uses: openai/codex-action@52fe01ec70a42f454c9d2ebd47598f9fd6893d56 # v1.11

with:
openai-api-key: ${{ secrets.OPENAI_API_KEY }}
prompt-file: .github/ai-review/codex-review-prompt.md
Expand Down Expand Up @@ -495,7 +495,7 @@ jobs:
# its output file — the step sits idle until the job timeout, discarding
# a completed review (openai/codex-action#150). v1.11 handles the same
# heavy workload cleanly. There is no released fix above v1.12 yet.
uses: openai/codex-action@52fe01ec70a42f454c9d2ebd47598f9fd6893d56 # v1.11
uses: openai/codex-action@86365089eb2b84e0a8fb0717b304f8bdcb13b20e # v1.12
with:
openai-api-key: ${{ secrets.OPENAI_API_KEY }}
prompt-file: trusted/.github/ai-review/adjudicate-prompt.md
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cli-go-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ jobs:
with:
persist-credentials: false

- uses: jdx/mise-action@3c2e0cf82a5b2e5249f0d3635a4d83d0ae861518 # v4
- uses: jdx/mise-action@c2a87611a18de5b3828c5652fe268e992400cb5c # v4
with:
version: 2026.7.0
install: true
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/cli-go-codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@ff2f1c621b7f889edc0d3c761ac2e6a3f8cdb0dd # v4.37.7
uses: github/codeql-action/init@cdf488f595d80d6e07e03d4674febd5ab45fa938 # v4.37.9
with:
languages: ${{ matrix.language }}
build-mode: ${{ matrix.build-mode }}
Expand Down Expand Up @@ -95,7 +95,7 @@ jobs:
exit 1

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@ff2f1c621b7f889edc0d3c761ac2e6a3f8cdb0dd # v4.37.7
uses: github/codeql-action/analyze@cdf488f595d80d6e07e03d4674febd5ab45fa938 # v4.37.9
with:
category: "/language:${{matrix.language}}"
defaults:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release-shared.yml
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ jobs:

- name: Sync stable release to Linear
if: ${{ inputs.channel == 'stable' && env.LINEAR_CLI_STABLE_RELEASE_ACCESS_KEY != '' }}
uses: linear/linear-release-action@17b8c24f8ceb2b98cabaf1965ff83c55dd596fac # v0
uses: linear/linear-release-action@e1ca7cace602cb66768264790a2b316630877148 # v0
with:
access_key: ${{ env.LINEAR_CLI_STABLE_RELEASE_ACCESS_KEY }}
version: v${{ inputs.version }}
Expand All @@ -437,7 +437,7 @@ jobs:

- name: Sync beta release to Linear
if: ${{ inputs.channel == 'beta' && env.LINEAR_CLI_BETA_RELEASE_ACCESS_KEY != '' }}
uses: linear/linear-release-action@17b8c24f8ceb2b98cabaf1965ff83c55dd596fac # v0
uses: linear/linear-release-action@e1ca7cace602cb66768264790a2b316630877148 # v0
with:
access_key: ${{ env.LINEAR_CLI_BETA_RELEASE_ACCESS_KEY }}
version: v${{ inputs.version }}
Expand Down
Loading