-
Notifications
You must be signed in to change notification settings - Fork 516
chore(ci): bump the actions-major group across 1 directory with 5 updates #6413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -331,7 +331,7 @@ jobs: | |||||
| # its output file — the step sits idle until the job timeout, discarding | ||||||
| # a completed review (openai/codex-action#150). v1.11 handles the same | ||||||
| # heavy workload cleanly. There is no released fix above v1.12 yet. | ||||||
| uses: openai/codex-action@52fe01ec70a42f454c9d2ebd47598f9fd6893d56 # v1.11 | ||||||
| uses: openai/codex-action@86365089eb2b84e0a8fb0717b304f8bdcb13b20e # v1.12 | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Severity: MEDIUM Pinning v1.12 here reintroduces the known Linux completion failure documented in openai/codex-action#150. For sufficiently heavy reviews, Codex writes its output but never exits; this step then times out before validation/artifact upload, so adjudication loses this independent security review. 💡 Fix SuggestionSuggestion: Revert the
Suggested change
|
||||||
| with: | ||||||
| openai-api-key: ${{ secrets.OPENAI_API_KEY }} | ||||||
| prompt-file: .github/ai-review/codex-review-prompt.md | ||||||
|
|
@@ -495,7 +495,7 @@ jobs: | |||||
| # its output file — the step sits idle until the job timeout, discarding | ||||||
| # a completed review (openai/codex-action#150). v1.11 handles the same | ||||||
| # heavy workload cleanly. There is no released fix above v1.12 yet. | ||||||
| uses: openai/codex-action@52fe01ec70a42f454c9d2ebd47598f9fd6893d56 # v1.11 | ||||||
| uses: openai/codex-action@86365089eb2b84e0a8fb0717b304f8bdcb13b20e # v1.12 | ||||||
| with: | ||||||
| openai-api-key: ${{ secrets.OPENAI_API_KEY }} | ||||||
| prompt-file: trusted/.github/ai-review/adjudicate-prompt.md | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this pin to v1.11 until the documented regression is fixed. As the immediately preceding workflow comment records from
openai/codex-action#150, v1.12 can hang after completing a heavy Linux run and writing its output, so this step waits until the 45-minute job timeout and discards a completed review. The same v1.12 pin is also introduced in the adjudication job, allowing either stage to prevent the AI review from being posted.Useful? React with 👍 / 👎.