fix(columns): expose domain identity on domain-typed columns - #1135
Open
hsusul wants to merge 1 commit into
Open
fix(columns): expose domain identity on domain-typed columns#1135hsusul wants to merge 1 commit into
hsusul wants to merge 1 commit into
Conversation
Studio and other consumers need the domain name to label columns correctly. Keep data_type and format as the base type for compatibility, and add domain_schema/domain_name when the column type is a DOMAIN. Closes supabase#1092
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
domain_schemaanddomain_nameto the columns introspection API when a column's type is a PostgreSQLDOMAINdata_typeandformatreporting the domain's base type (matchinginformation_schema.columns) so existing consumers stay compatiblejsonb/textCloses #1092
Why this matters
Domain types are common for validated columns (EQL, custom search types, constrained integers). Without domain identity in the API, Studio's schema visualizer and table editor collapse everything to the base type.
Test plan
domain-typed columns expose domain identityregression test against fixture domainstext_search(jsonb) andpositive_int(int4)domain_schema/domain_name(null for non-domain columns)