[Rector] Skip deprecated rules in set + check bare int refactor() return - #277
Merged
Conversation
…torReturnRule, keep REMOVE_NODE allowed
TomasVotruba
force-pushed
the
skip-deprecated-rector-rules-in-set
branch
from
August 24, 2026 18:29
79012fe to
ddd05c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two
src/Rules/Rector/improvements.1.
PhpUpgradeDowngradeRegisteredInSetRule— skip deprecated rulesThe rule demands every
Php*/DowngradePhp*Rector rule be registered in its matching config set:Deprecated rules (marker
Rector\Configuration\Deprecation\Contract\DeprecatedInterface) are on their way out and are not registered in sets, so they are now skipped — same treatment asConfigurableRectorInterface.2.
NoIntegerRefactorReturnRule— also check bareintreturn typePreviously only a
UnionTypereturn type (e.g.Node|int) was inspected; a bareintreturn type slipped through unchecked. Now bareintis checked too, whileREMOVE_NODEstays allowed.