fix: address review follow-ups on the canvas stack - #150
Merged
Merged
Conversation
librowski
added this pull request to stack #151
September 15, 2026 10:25
librowski
marked this pull request as ready for review
September 15, 2026 11:12
librowski
requested review from
lukasz-jazwa,
piotrblaszczyk and
szymon-t-sc
as code owners
September 15, 2026 11:12
This was referenced Sep 15, 2026
Merged
piotrblaszczyk
approved these changes
Sep 15, 2026
librowski
force-pushed
the
ds2-review-follow-ups
branch
from
September 16, 2026 11:37
a2febe0 to
f925eae
Compare
- persist: strip the runtime dragging flag alongside measured and selected, drop dragging from the bundled templates, cover getStoreDataForIntegration - node description: document the contain: inline-size constraint - connectable item: rewrite the width decision log with the current numbers and a status section; reword the tooltip changeset - menu: lay out the RadioGroup wrapper as a column so the list-box gap applies - ui specs: unmount the React root after each test - palette: forward disabled in the custom template guide and the demo multi-port template, document it on NodePanel.Root, reword the changeset
- rows: in the horizontal layout Decision branches and AI tools fill the section width like the design's Node / Row; the derived cap and the Decision max-content rule now apply to the DOWN layout only; branch and tool rows are spaced with the node body gap - self-loop: the apex sits 48px above the node's top edge regardless of node height and port position; getSelfLoopHeight is exported - node text: follow-up markers for the DS Tooltip decided for 3.1 - demo: the multi-port template forwards disabled to icon and description
librowski
force-pushed
the
ds2-review-follow-ups
branch
from
September 16, 2026 11:47
f925eae to
9674d72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups from the second review round on the canvas stack (#124, #126, #136, #139, #140), plus the code side of the design answers from 16.09. The reviewed PRs are approved, so the fixes land here on top of #149.
Review follow-ups (commit 1)
Persist without measured (#124)
getNodesWithoutDynamicValuesalso strips the runtimedraggingflag; the bundled Demo and AI Studio templates no longer carrydragging: false.getStoreDataForIntegrationgets two boundary tests; changeset mentionsdragging.Node text ellipsis (#126)
contain: inline-sizeconstraint (definite inline size on an ancestor; collapses insideinline-flexorfit-content).Node body spacing (#136)
## Statussection, no external tracker reference; tooltip changeset reworded.Menu item selected (#139)
Menu.RadioGroupwrapper gets.group(column flex,--wb-public-list-box-gap), measured 4px between radio items;menu.spec.tsxandnode-panel.spec.tsxunmount the React root after each test.Palette node states (#140)
disabledtoNodePanel.Root,NodeIconandNodeDescription;node-panel.mdxlistsdisabled?: boolean; changeset written aroundWorkflowNodeTemplateProps.disabledwith a migration note.Design answers of 16.09 (commit 2)
Node / Row(width: 100%,min-width: 0, no cap); 205px at 241 is the reference value (design draws 209 because a Figma stroke takes no layout space). The derived cap and the Decisionmin-width: max-contentrule now apply to the DOWN layout only, which has no design master. Branch rows and tool rows are spaced with--wb-ds-canvas-node-body-gap(8px; was 4px hard-coded in both places). Decision log updated, theconnectable-item-design-widthfollow-up is closed.SELF_CONNECTING_EDGE_LABEL_OFFSETis48and measured from the top edge, as its JSDoc always said;getSelfLoopHeightis exported. Measured in Demo: 48px in the RIGHT layout; 44px in DOWN, where xyflow anchors the bottom port on its outer edge.(follow-up: node-text-ds-tooltip)markers on thetitleattributes inNodeDescriptionandConnectableItem.disabledtoNodeIconandNodeDescription(review remark on commit 1).Checks
pnpm -F @workflowbuilder/ui build(includescheck:built-css), vitest ui 74 and sdk 219 passing, stylelint ui/sdk clean, typecheck ui/sdk/demo/ai-studio clean.