chore: type-check spec files in demo and ai-studio - #153
Merged
Merged
Conversation
librowski
requested review from
lukasz-jazwa,
piotrblaszczyk and
szymon-t-sc
as code owners
September 15, 2026 11:08
piotrblaszczyk
approved these changes
Sep 15, 2026
Both app tsconfigs excluded spec and test files, so the pre-commit `tsc --noEmit` from lint-staged and `pnpm check` never saw them. CI does not type-check these apps by design (see pr-check.yml). The exclusion predates the first tests in these apps; removing it needs no code changes. `vitest/globals` joins `types` in both apps, as in the packages, so a spec that relies on `test.globals` type-checks too.
librowski
force-pushed
the
chore/typecheck-app-specs
branch
from
September 16, 2026 11:37
906deb0 to
b765428
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/demoandapps/ai-studioexcludedsrc/**/*.spec.*andsrc/**/*.test.*from their tsconfig, so the pre-committsc --noEmitfrom lint-staged andpnpm checknever type-checked tests and stayed green with type errors in them. CI does not type-check these apps by design (pr-check.ymlheader). Both exclusions come from the initial 2.0.0 import, before either app had a test.packages/sdkandpackages/uialready type-check their specs.Neither tsconfig emits anything (vite builds the apps), so the exclusion only removed a check.
Changes
apps/demo/tsconfig.jsonandapps/ai-studio/tsconfig.json:excludekeeps onlydist;"vitest/globals"joinstypes, as in the packages, so a spec written againsttest.globals(no vitest import) type-checks instead of failing with TS2593.Checks
pnpm -F @workflow-builder/demo typecheckandpnpm -F ai-studio typecheckpass with no code changes.const probe: number = 'x'appended todetect-format.test.tsfails the AI Studio typecheck; a spec using baredescribe/it/expecttype-checks withvitest/globalsand fails without it.