Skip to content

feat: expose serialized extended public keys - #126

Merged
ovitrif merged 2 commits into
masterfrom
feat/serialized-extended-pubkey
Aug 3, 2026
Merged

feat: expose serialized extended public keys#126
ovitrif merged 2 commits into
masterfrom
feat/serialized-extended-pubkey

Conversation

@ben-kaufman

@ben-kaufman ben-kaufman commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add serialized_extended_pubkey using Rust Bitcoin's BIP32 Xpub parser and canonical 78-byte encoder
  • reject invalid Base58 characters, invalid checksums, and Base58Check payloads that are not valid extended public keys
  • expose the result as Swift Data, Kotlin ByteArray, and Python bytes
  • rebase onto current master, including the latest Boltz and Android publishing changes
  • bump the release version from 0.5.4 to 0.5.5 and regenerate all platform bindings
  • use master's current iOS artifact policy: ship the XCFramework zip without tracking duplicate unpacked static libraries

Verification

  • ./build.sh all — passed for iOS, all four Android ABIs, and Python
  • Android Maven Local publish validation — passed
  • cargo test extended_pubkey --locked — 6 passed
  • generated APIs verified as Swift Data, Kotlin ByteArray, and Python bytes

The strict repository gates remain blocked by existing master issues: cargo fmt --check reports formatting drift in activity/backup_migration.rs, and cargo clippy -- -D warnings reports 30 pre-existing warnings across unrelated modules. The new extended-key module introduces none.

@ben-kaufman
ben-kaufman force-pushed the feat/serialized-extended-pubkey branch from dd99b46 to 3cb8811 Compare August 3, 2026 06:48
@ben-kaufman
ben-kaufman marked this pull request as ready for review August 3, 2026 06:48

@ovitrif ovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@ovitrif
ovitrif merged commit 6a29c6c into master Aug 3, 2026
1 check passed
@ovitrif
ovitrif deleted the feat/serialized-extended-pubkey branch August 3, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants