Conversation
PR #1852 (parse <statusNotes> into JobItem.status_notes) added a structured list[dict] surface for modern job types, but this sample still only printed the legacy list[str] `notes` attribute. Modern jobs (extract refresh v2 shapes and later) surface their diagnostics via `status_notes`; the sample now prints both so running `list_jobs.py --wait <job_id>` against a real server exercises the #1852 parser end to end. Zero library changes.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Updates the list_jobs.py sample to print structured status_notes alongside legacy notes.
Changes:
- Adds
status_notesto successful job output. - Adds
status_notesto failed job output.
| File | Description |
|---|---|
samples/list_jobs.py |
Prints both job note fields. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#1852 added a structured
list[dict]status_notesattribute onJobItemfor modern job types (extract refresh v2 and later). Thelist_jobs.pysample from #1843 still only printed the legacylist[str]notesattribute, so running the sample against a live server never exercised the new parser.Behavior
Sample only. Both fields print in the wait-for-job output:
Same shape on the
JobFailedExceptionfailure path. No library changes.