Audit and fix repository consistency issues - #339
Draft
jackspiering wants to merge 4 commits into
Draft
jackspiering wants to merge 4 commits into
jackspiering wants to merge 4 commits into
Conversation
jackspiering
commented
Sep 14, 2026
jackspiering
left a comment
Collaborator
Author
There was a problem hiding this comment.
Reviewed the 177-file diff and pushed three follow-up commits. The review found the following issues in the changed setup guidance and configuration:
- Caddy hostname changes break the healthcheck (P2). The new README removes the old workaround, but
SERVICE=my-proxymakes the check search formy-proxy. The executable remainscaddy. Fixed the check to use the process name in c1663ab. - Caddy retains a stale socket after a Tailscale restart (P2). The updated socket sharing still binds the individual socket into Caddy. A replacement socket leaves that mount attached to the old inode. A disposable Docker test reproduced this behavior. Commit c1663ab shares the directory instead.
- Tracktor setup produces an invalid allowed origin (P2). The new instruction asks for the DNS suffix, but entering
tail123.ts.netproduceshttps://tracktor.tail123.ts.net.ts.net. The existing environment entry also preserves literal quote characters. Commit 85dce10 clarifies the input and removes those quotes. This matches Tracktor's origin parsing, which trims whitespace but retains quotes. - Two catalog links break on GitHub (P3). GitHub preserves the emoji variation selector in the Development Tools and Food & Wellness heading anchors. The replacement links omit it. Commit 40264c7 adds explicit anchors that work with GitHub and the Markdown linter.
Validation:
- All 122 service configurations parse with Docker Compose 5.5.1, with a temporary dummy JWT supplied for Seafile. All 112 embedded Serve JSON documents parse.
- All 127 Markdown files pass both the CI-pinned rumdl 0.2.41 and local 0.2.54.
- Targeted Compose assertions pass for default and renamed Caddy/Tracktor hostnames, the shared socket directory, and unquoted origins with one
.ts.netsuffix. - GitHub rendering preserves both new anchors. All 23 README fragment links match the existing GitHub heading IDs or the new explicit anchors.
- A network-disabled disposable container using the existing Alpine image confirmed the socket replacement behavior and was removed afterward.
git diff --checkpasses; the working tree is clean.
I found no further blocking issues in the reviewed diff. Full application startup and Tailnet behavior remain unverified. No service stacks were started, images pulled, or Tailnet connections made. GitHub currently reports no check runs for the latest commit, so the validation above is local.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repository consistency audit and fixes
Description
Audited all 122 service stacks, the shared template, deployment documentation, the root service catalog, and CI. This PR fixes confirmed functional inconsistencies and documentation drift while preserving service-specific storage, identities, images, credentials, and access patterns.
Key changes include:
Related Issues
Verification
docker compose config --quietfrom each service directory: 121/122 pass with committed values. Seafile is the only expected failure becauseJWT_PRIVATE_KEYis intentionally empty.JWT_PRIVATE_KEY=audit-dummy: 122/122 pass with no warnings.docker compose config --format json: 122/122 parse successfully.rumdl check . --config .markdownlint.yml: passes all 127 Markdown files.git diff --check: passes.Checklist
Additional Context