feat: support iso date for intervals - #123
Conversation
231f8c8 to
3ec3516
Compare
|
Hi Max! Took a look at the code — it's done carefully, and I verified the test strings against the real My question is not about the implementation, but about where this code should live. As far as I understand, there is exactly one consumer here — our CDC, which needs intervals in the Debezium format. If that's the case, I'd suggest moving the converter there and closing this PR. Reasoning:
Nothing extra would be needed from the SDK for this: The counterargument I can see: if we expect other consumers of a string format besides our CDC. Then keeping it in the SDK makes sense, but the format should probably not be Debezium-specific, and that's a separate task with a proper description (TNTP-10067 is currently empty, no acceptance criteria). What do you think? If you agree, I suggest closing this PR and re-filing the task against CDC. If we do keep it in the SDK, I'll write up detailed code comments — besides the |
Closes TNTP-10067
3ec3516 to
6758d8d
Compare
|
@ArtDu After a discussion with @bitgorbovsky in the TJ EE chat, we decided to add this feature without mentioning Debezium anywhere. I've already pushed new changes. |
Closes TNTP-10067
I haven't forgotten about:
Related issues: