fix: allow table deletion confirmation requests T6924 - #145
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deleted-table collaborator runner aborts every request containing the target table ID. That now also blocks the table-detail GET used to distinguish deletion from a temporarily omitted provisioning table, making correct network-error handling look like a deletion-recovery regression.
Allow only that GET to reach the backend via route.fetch/fulfill; stale record and snapshot requests remain aborted. Keep all existing deletion, navigation, routing and page-error assertions. Update the case documentation to explain the distinction.
Validation:
pnpm checkpassed. Browser acceptance should compare the original unfixed revision and the updated product commit with this runner.Unblocks the harness failure reported in teableio/teable-ee#3419 (T6660); the original deletion case is T6924.