💥 Drop activity unpause --reset-attempts and --reset-heartbeats - #1159
Open
dandavison wants to merge 1 commit into
Open
💥 Drop activity unpause --reset-attempts and --reset-heartbeats#1159dandavison wants to merge 1 commit into
activity unpause --reset-attempts and --reset-heartbeats#1159dandavison wants to merge 1 commit into
Conversation
…nRequest
go.temporal.io/api reserved fields 6/7 (reset_attempts, reset_heartbeat) on
UnpauseActivityExecutionRequest, so the single-execution unpause path no
longer compiles. The batch path keeps its equivalents, which still exist on
BatchOperationUnpauseActivities.
Tests:
go test ./internal/temporalcli -run 'TestSharedServerSuite/TestActivity' -count=1
spkane31
approved these changes
Aug 7, 2026
chaptersix
marked this pull request as draft
August 7, 2026 19:25
chaptersix
marked this pull request as ready for review
August 7, 2026 19:25
Contributor
|
trigger ci. github incident. |
chaptersix
enabled auto-merge
August 7, 2026 19:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Drop
activity unpause--reset-attemptsand--reset-heartbeatsWhy
A design decision was made to remove these from SAA and WFA APIs. Users should use
activity resetfor this functionality.Checklist
Stability