Add dev server downloader & runner to testing package - #2982
Open
Sushisource wants to merge 4 commits into
Open
Conversation
Sushisource
changed the title
Sushisource
force-pushed
the
sj/dev-server-gradle
branch
from
July 31, 2026 22:41
4430dcc to
6c827c9
Compare
| * <pre>{@code | ||
| * TestWorkflowRule.newBuilder() | ||
| * .useDevServer( | ||
| * TemporalDevServerOptions.newBuilder().setDownloadVersion("1.7.2").build()) |
Contributor
There was a problem hiding this comment.
Suggested change
| * TemporalDevServerOptions.newBuilder().setDownloadVersion("1.7.2").build()) | |
| * TemporalDevServerOptions.newBuilder().setDownloadVersion("v1.7.2").build()) |
|
|
||
| import java.util.concurrent.TimeUnit | ||
|
|
||
| abstract class TemporalDevServerTestService |
Contributor
There was a problem hiding this comment.
Think it would be simpler to just move this into the SDK test rule?
| } | ||
|
|
||
| /** Starts a dev server for the supplied namespace and options. */ | ||
| public static TemporalDevServer start(String namespace, TemporalDevServerOptions options) { |
Contributor
There was a problem hiding this comment.
Nit: could use some non null annotations
Contributor
|
We should make a follow up issue to update our docs and samples to show how to do this |
| } | ||
| this.useDevServer = true; | ||
| this.useExternalService = false; | ||
| this.target = null; |
Contributor
There was a problem hiding this comment.
Should we document these are mutually exclusive?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Added an experimental dev-server API to temporal-testing, including configurable CLI download/cache support, readiness checks, process ownership, TestWorkflowEnvironment integration, and JUnit rule/extension support.
Repository tests now use the same Java-owned server through -PtestServer=dev-server. Gradle only prepares and activates the profile, while CI and contributor documentation use the new commands. Server lifecycle coverage runs against the pinned real CLI.
Why?
This makes local dev-server ownership reusable by SDK users and tools such as flake verification, while keeping sdk-java tests on the same implementation instead of maintaining a separate Gradle process runner.
Breaking changes?
None. The unreleased useTemporalCli profile and preparation task were replaced without compatibility aliases.
Server PR
None.
Testing