Skip to content

Move Cloud Run OpenTelemetry plugin to temporal-gcp-cloud-run-opentelemetry #3064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seanbollin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move Cloud Run OpenTelemetry plugin to temporal-gcp-cloud-run-opentelemetry #3064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contrib/temporal-gcp-cloud-run/README.md → ...ral-gcp-cloud-run-opentelemetry/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Temporal Google Cloud Run module
# Temporal Google Cloud Run OpenTelemetry module

This module provides an OpenTelemetry plugin with defaults for Temporal Java SDK workers running on Google Cloud Run. Cloud Run worker pools are the recommended deployment because Temporal workers are continuous, pull-based background workloads.

Expand All @@ -10,7 +10,7 @@ A Cloud Run service can also host a Temporal worker, but it must use instance-ba

## Usage

Add `temporal-gcp-cloud-run` next to your Temporal SDK dependency, then install the plugin on service stubs options before creating clients and workers:
Add `temporal-gcp-cloud-run-opentelemetry` next to your Temporal SDK dependency, then install the plugin on service stubs options before creating clients and workers:

```java
CloudRunOpenTelemetryPlugin plugin = CloudRunOpenTelemetryPlugin.newBuilder().build();
Expand Down
0 contrib/temporal-gcp-cloud-run/build.gradle → ...-gcp-cloud-run-opentelemetry/build.gradle
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...cloudrun/CloudRunOpenTelemetryPlugin.java → ...elemetry/CloudRunOpenTelemetryPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package io.temporal.gcp.cloudrun;
package io.temporal.gcp.cloudrun.opentelemetry;

import io.opentelemetry.api.OpenTelemetry;
import io.temporal.client.WorkflowClientOptions;
Expand Down
2 changes: 1 addition & 1 deletion ...drun/CloudRunOpenTelemetryPluginTest.java → ...etry/CloudRunOpenTelemetryPluginTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package io.temporal.gcp.cloudrun;
package io.temporal.gcp.cloudrun.opentelemetry;

import static org.junit.Assert.*;

Expand Down
4 changes: 2 additions & 2 deletions settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ include 'temporal-workflowstreams'
project(':temporal-workflowstreams').projectDir = file('contrib/temporal-workflowstreams')
include 'temporal-aws-lambda'
project(':temporal-aws-lambda').projectDir = file('contrib/temporal-aws-lambda')
include 'temporal-gcp-cloud-run'
project(':temporal-gcp-cloud-run').projectDir = file('contrib/temporal-gcp-cloud-run')
include 'temporal-gcp-cloud-run-opentelemetry'
project(':temporal-gcp-cloud-run-opentelemetry').projectDir = file('contrib/temporal-gcp-cloud-run-opentelemetry')
include 'temporal-spring-boot-autoconfigure'
include 'temporal-spring-boot-starter'
include 'temporal-remote-data-encoder'
Expand Down
2 changes: 1 addition & 1 deletion temporal-bom/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ dependencies {
api project(':temporal-opentelemetry')
api project(':temporal-opentracing')
api project(':temporal-aws-lambda')
api project(':temporal-gcp-cloud-run')
api project(':temporal-gcp-cloud-run-opentelemetry')
api project(':temporal-remote-data-encoder')
api project(':temporal-sdk')
api project(':temporal-serviceclient')
Expand Down
Loading