Fix test server dropping headers on signals - #3066
Open
sangkyoonnam wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
TestWorkflowMutableStateImpl#addExecutionSignaledEventnow copies the header from the signal request onto theWorkflowExecutionSignaledevent.SignalHeaderTestcovering header propagation through the test server on a direct signal.Why?
The time-skipping test server built the signaled event from
identity,input, andsignalNameonly, so headers set on a signal were dropped and never reached the inbound workflow interceptor. The child-workflow and activity paths in thesame file already copy the header the same way.
Checklist
Closes Time skipping server drops headers in workflow signal #2586
How was this tested:
New
SignalHeaderTestsets a header on a signal through a client interceptor and asserts the inbound workflow interceptor receives it. Run with./gradlew :temporal-sdk:test --tests "io.temporal.workflow.signalTests.SignalHeaderTest". It fails onmainwithexpected:<signal-header-value> but was:<null>and passes with the fix.Any docs updates needed?
No.