fix: cache nowSeconds() and handle negative BigInt in format functions - #89
Open
Sertug17 wants to merge 1 commit into
Open
fix: cache nowSeconds() and handle negative BigInt in format functions#89Sertug17 wants to merge 1 commit into
Sertug17 wants to merge 1 commit into
Conversation
- Cache nowSeconds() in sessionItem to prevent TOCTOU race producing negative remaining_secs - Handle negative BigInt values in formatTokenUnits and formatCreditBalance Fixes tempoxyz#87 Fixes tempoxyz#88
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nowSeconds()call insessionItemto prevent TOCTOU race that can produce negativeremaining_secs(fixes sessionItem calls nowSeconds() twice in ternary, can produce negative remaining_secs #87)bigintvalues informatTokenUnitsandformatCreditBalanceto prevent malformed output like"0.0000-5"(fixesformatTokenUnitsandformatCreditBalanceproduce malformed output for negative BigInt values #88)Changes
src/commands/sessions.ts: CachenowSeconds()in a local variable before the ternary, matching the pattern already used incloseOneSessionsrc/shared/utils.ts: Extract absolute value before division/remainder, prepend-prefix for negative inputs