Conversation
Explicitly allow com.diffplug.spotless in the root Gradle Dependabot configuration so Dependabot can create Spotless update PRs.
Add spotless dependency to Dependabot configuration
Enumerate check tasks without executing their dependencies, avoiding Greclipse initialization during matrix discovery. Write matrix JSON to a dedicated file and validate it before publishing workflow outputs.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe pull request upgrades Spotless to 8.10.1, allows Dependabot to update Spotless, and adds file-based test-matrix output with strict validation for Gradle CI jobs. ChangesGradle CI and Spotless maintenance
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant GitHubActions
participant GradleTestMatrix
participant jq
GitHubActions->>GradleTestMatrix: Run testMatrix with testMatrixOutput
GradleTestMatrix->>GitHubActions: Write task paths to the output file
GitHubActions->>jq: Validate the task-path array
jq-->>GitHubActions: Return validated matrix data
Merge Risk: ⚪ Minimal · up to The CI matrix generation paths are consistently wired and validate their output, with no actionable merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Builds on #12003 and includes its Spotless upgrade from 6.22.0 to 8.10.1 and Dependabot allow-list change, addressing #11997.
With the upgraded formatter, Greclipse can print resolver startup messages to stdout during
testMatrix, causing the workflow'sjqparser to fail and skip all downstream matrix jobs. MaketestMatrixenumerate check tasks without executing their dependencies, and remove the obsolete test-executor overrides. The generated task list and downstream checks are preserved.Write matrix JSON to a dedicated file in CI so other Gradle output cannot corrupt it. Validate the root, examples, and docs matrices as non-empty arrays of task paths, reject empty filtered matrices, and propagate generation or parsing failures before publishing workflow outputs. Local callers can continue using stdout when no output file is specified.
Summary by CodeRabbit
Bug Fixes
Chores