Skip to content

Close Docker log streams when consumers stop reading - #1432

Merged
cristianrgreco merged 1 commit into
testcontainers:mainfrom
0xTinker:codex/close-docker-log-stream
Aug 9, 2026
Merged

Close Docker log streams when consumers stop reading#1432
cristianrgreco merged 1 commit into
testcontainers:mainfrom
0xTinker:codex/close-docker-log-stream

Conversation

@0xTinker

@0xTinker 0xTinker commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • close the demuxed log stream when a consumer closes the public log stream
  • cover the stream ownership chain with a regression test

This lets Bun exit after Ryuk’s log wait completes. The change is non-breaking: it only releases the underlying Docker follow stream after the caller has already closed the returned stream.

Verification

  • focused test failed before the fix and passed after it
  • npm run format
  • npm run lint
  • npm run check-compiles
  • Bun 1.3.14 reproduction exits naturally

Closes #1431

Co-authored-by: 0xRaduan <alshed.rad@gmail.com>
@netlify

netlify Bot commented Aug 9, 2026

Copy link
Copy Markdown

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 68c8cd5
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-node/deploys/6a7841aa7ff15f0008338d32
😎 Deploy Preview https://deploy-preview-1432--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cristianrgreco cristianrgreco added bug Something isn't working patch Backward compatible bug fix labels Aug 9, 2026
@cristianrgreco
cristianrgreco merged commit 99ff0a2 into testcontainers:main Aug 9, 2026
269 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working patch Backward compatible bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bun stays alive after a log wait completes

2 participants