Route File and UploadedFile moves through WP_Filesystem instead of raw PHP calls - #13
Merged
Merged
Conversation
…w PHP calls rename(), chmod(), mkdir(), is_writable(), and move_uploaded_file() are flagged or forbidden by WordPress.org's Plugin Check. File::move()/get_target_file() and UploadedFile::move() now go through wp_mkdir_p()/wp_is_writable() and a lazily-resolved Filesystem (WP_Filesystem) instance instead, matching the pattern Cache/Stores/FileStore.php already uses. Upload-source verification via is_uploaded_file() is unchanged. Adds unit test coverage for both move() paths using a disk-backed Filesystem test double bound into the container. Verified against the real WordPress.org Plugin Check (plugin_review_phpcs) and a live HTTP upload through actual WP_Filesystem in the Docker playground.
The non-scalar guard added for SessionManager's cookie safety fired
unconditionally, so Superglobals::query('key', $default, Sanitizer::ARRAY)
always fell back to $default instead of returning the array, even though
Sanitizer::apply_rule()'s ARRAY case already handles arrays correctly.
Now the guard is skipped when the caller explicitly asked for
Sanitizer::ARRAY.
ahamed
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rename(), chmod(), mkdir(), is_writable(), and move_uploaded_file() are flagged or forbidden by WordPress.org's Plugin Check. File::move()/get_target_file() and UploadedFile::move() now go through wp_mkdir_p()/wp_is_writable() and a lazily-resolved Filesystem (WP_Filesystem) instance instead, matching the pattern Cache/Stores/FileStore.php already uses. Upload-source verification via is_uploaded_file() is unchanged. Adds unit test coverage for both move() paths using a disk-backed Filesystem test double bound into the container.
Verified against the real WordPress.org Plugin Check (plugin_review_phpcs) and a live HTTP upload through actual WP_Filesystem in the Docker playground.