ipc4: helper: unlock module instance verbs on native_sim - #11062
Merged
kv2019i merged 1 commit intoAug 7, 2026
Merged
Conversation
tmleman
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
August 5, 2026 12:27
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes IPC4 module driver resolution on native_sim fuzz builds by adding a CONFIG_ARCH_POSIX_LIBFUZZER fallback path in ipc4_get_comp_drv(), enabling fuzzer reachability of IPC4 module instance verbs that previously always failed due to missing rimage manifest support.
Changes:
- Add a
CONFIG_ARCH_POSIX_LIBFUZZERbranch to resolvemodule_idby walking the runtimecomp_driverregistry. - Restrict the mapping to instantiable drivers (
ops.createpresent) and IPC4-relevant module-adapter drivers (type == SOF_COMP_MODULE_ADAPTER). - Return the resolved
comp_driverdirectly instead of doing a redundant UUID re-lookup.
Contributor
Author
|
Need to wait for: #11066 |
lyakh
reviewed
Aug 6, 2026
kv2019i
reviewed
Aug 6, 2026
kv2019i
left a comment
kv2019i
left a comment
Collaborator
There was a problem hiding this comment.
I think separating the fuzzer-only code is a good idea. Otherwise looks good.
tmleman
force-pushed
the
topic/upstream/pr/fuzzing/enhancement/part8
branch
2 times, most recently
from
August 7, 2026 10:55
be29621 to
d63db5b
Compare
tmleman
requested review from
abonislawski,
kv2019i,
lyakh,
serhiy-katsyuba-intel,
softwarecki and
wjablon1
August 7, 2026 10:55
serhiy-katsyuba-intel
approved these changes
Aug 7, 2026
ipc4_get_comp_drv() returned NULL unconditionally on native_sim because the RIMAGE_MANIFEST guard (Intel ADSP ACE/CAVS only) was the sole path to a driver UUID lookup. Every INIT_INSTANCE call therefore failed with IPC4_MOD_NOT_INITIALIZED before creating any comp_dev, making the entire module instance verb surface (CONFIG_GET/SET, LARGE_CONFIG on real modules, BIND, UNBIND, DELETE_INSTANCE) unreachable from the fuzzer. Resolve module drivers on native_sim from a small fuzzer-only helper, ipc4_get_fuzzer_drv(), called from the CONFIG_ARCH_POSIX_LIBFUZZER branch of ipc4_get_comp_drv() so the heavily-used manifest lookup path is left untouched. It mirrors the IPC3 whitebox hack in posix/ipc.c: module_id is a 1-based index into the runtime component driver list, counting only instantiable module-adapter drivers so the fuzzer's module_id space matches what a real signed manifest exposes. Drivers with no ops.create, and internal gateway drivers (SOF_COMP_HOST/DAI) that are never IPC4 modules, are skipped (otherwise a module_id could land on an unconfigurable component or a NULL create op). module_id 0 (BaseFW) intentionally resolves to NULL: BaseFW is never created as a pipeline component, its messages are dispatched directly by base_fw.c. A tr_err() logs any module_id that maps to no driver to help developers and agents triage. The change is inactive in all non-fuzz builds. Measured impact (UBSan IPC4, seed=1, 20 s, small corpus): cov ~558 -> ~3974 (~7x lift from previously dead module instance paths) Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
kv2019i
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ipc4_get_comp_drv() returned NULL unconditionally on native_sim because the RIMAGE_MANIFEST guard (Intel ADSP ACE/CAVS only) was the sole path to a driver UUID lookup. Every INIT_INSTANCE call therefore failed with IPC4_MOD_NOT_INITIALIZED before creating any comp_dev, making the entire module instance verb surface (CONFIG_GET/SET, LARGE_CONFIG on real modules, BIND, UNBIND, DELETE_INSTANCE) unreachable from the fuzzer.
Add a CONFIG_ARCH_POSIX_LIBFUZZER branch that mirrors the existing IPC3 whitebox hack in posix/ipc.c: treat module_id as a 1-based index into the runtime comp_driver list. module_id 0 (BaseFW, handled separately and having no create callback) is excluded. Drivers without an ops.create callback are skipped during the index walk so the fuzzer's module_id space only maps to instantiable components, otherwise a module_id that lands on such a driver would cause a NULL function pointer call. Return the resolved driver directly instead of a redundant UUID re-lookup. The change is inactive in all non-fuzz builds.
Measured impact (UBSan IPC4, seed=1, 20 s, small corpus):
cov ~558 -> ~3974 (~7x lift from previously dead module instance paths)