topology2: add d0i3_compatible properties to host-copier widget - #11111
Open
jsarha wants to merge 1 commit into
Open
topology2: add d0i3_compatible properties to host-copier widget#11111jsarha wants to merge 1 commit into
jsarha wants to merge 1 commit into
Conversation
Add playback_compatible_d0i3 and capture_compatible_d0i3 attributes to the host-copier widget class so they can be set on host-copier widgets to enable Wake on Voice and similar functionalities for the associated PCMs. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds D0i3 compatibility flags to the host-copier widget class in topology2 so topology authors can mark host-copier widgets as D0i3-compatible for features like Wake on Voice (completing the linked Linux PR work).
Changes:
- Introduces
playback_compatible_d0i3andcapture_compatible_d0i3attributes inClass.Widget."host-copier". - Wires both attributes to the existing
stream.booltoken set (tokens already defined understream).
Suppressed comments (1)
tools/topology/topology2/include/components/host-copier.conf:96
- For consistency with other DefineAttribute blocks in this file, consider adding the
# Token set reference name and typecomment beforetoken_ref(see e.g. host-copier.conf:61-64).
DefineAttribute."capture_compatible_d0i3" {
token_ref "stream.bool"
}
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+90
to
+92
| DefineAttribute."playback_compatible_d0i3" { | ||
| token_ref "stream.bool" | ||
| } |
lgirdwood
reviewed
Aug 21, 2026
lgirdwood
left a comment
lgirdwood
left a comment
Member
There was a problem hiding this comment.
LGTM , just have one open for consistency with other definitions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add playback_compatible_d0i3 and capture_compatible_d0i3 attributes to the host-copier widget class so they can be set on host-copier widgets to enable Wake on Voice and similar functionalities for the associated PCMs.
This PR completes thesofproject/linux#5878