fix(export): grey Apply white balance for Trichrome and Single-Shot Narrowband - #5
Closed
thetalkingdrum wants to merge 1 commit into
Closed
fix(export): grey Apply white balance for Trichrome and Single-Shot Narrowband#5thetalkingdrum wants to merge 1 commit into
thetalkingdrum wants to merge 1 commit into
Conversation
…arrowband The as-shot WB gains a camera records assume a broadband scene; a narrowband capture (Trichrome's isolated exposures, or a Single-Shot Narrowband rig) has no such scene, so baking them into Linear Output has no practical use. wb_bake_block_reason() greys the checkbox for both cases and makes the bake inert in _decode_linear even if a stale sticky preference has it checked.
Owner
Author
|
Reopened against upstream: marcinz606#954 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply white balancein Linear Output's Corrections block used to stay clickable forTrichrome triplets and Single-Shot Narrowband captures, even though baking the as-shot
gains into either has no practical use: the gains correct a broadband scene, and a
narrowband capture (three isolated exposures, or a narrowband-lit single shot) has none.
wb_bake_block_reason()inlinear_output.py, checked from both the exportsidebar (greys the checkbox with an explanatory tooltip) and
_decode_linearitself(makes the bake inert even if a stale sticky preference has the box checked), so the
two can't disagree — same pattern as the existing sensor-unmix
unmix_block_reason.Narrowband toggle or a calibrated Single-Shot Narrowband sensor matrix, since a rig can
have one set without the other.
docs/USER_GUIDE.md/docs/PIPELINE.md, added unit + integration tests.Test plan
uv run pytest tests/test_linear_output.py tests/test_linear_output_batch.py tests/test_export_settings_form.pymake lint/make formatset_linear_outputsignal chain) across an ordinary camera RAW, a Trichrome triplet, a Single-Shot Narrowband (toggle) and a Single-Shot Narrowband (sensor matrix only) config —Apply white balancestayed enabled only for the ordinary RAW, with the correct tooltip on each greyed case.