Allow more time for local synchronizer responses - #299
Open
dajiaohuang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #298.
Restore the LocalSynchronizer request timeout from 10 ms to its earlier 50 ms value. Requests and responses are delivered asynchronously by timers; a 10 ms deadline can expire before an otherwise valid response arrives.
Add a fake-timer regression that delays each zero-delay delivery by 15 ms, and wait for convergence before the prepopulated bidirectional tests inspect their existing expected content and snapshots. No snapshots, dependencies, or public API are changed.
Tradeoff: a missing peer can take an additional 40 ms to time out. This provides headroom for the reproduced timer scheduling behavior, not a guarantee against arbitrary event-loop stalls.
How did you test this change?
compileForTestbuild passes.gulp tswrapper then hitsspawn npx ENOENTon Windows; running its two installed Svelte-check entrypoints directly gives zero errors/warnings in both workspaces.git diff --checkpass.Environment: Windows, Node.js v24.14.1. Full repository test coverage is not claimed.