Skip to content

docs(licenses): record initial dependency license review #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
josecelano wants to merge 5 commits into
base: develop
Choose a base branch
from
+5,934 −28
Open

docs(licenses): record initial dependency license review #2113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1daf4e2
docs(licenses): record initial dependency license review
josecelano Aug 28, 2026
aa42371
docs(licenses): clarify maintainer review actions
josecelano Aug 28, 2026
1f2d642
docs(licenses): add bloom legal review brief
josecelano Aug 28, 2026
8f7dfe5
docs(licenses): link bloom remediation issue
josecelano Aug 29, 2026
493d35d
docs(licenses): record bloom removal
josecelano Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contrib/dev-tools/analysis/workspace-coupling/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
[package]
description = "Generates a workspace coupling report for the Torrust Tracker workspace."
license.workspace = true
name = "workspace-coupling"
publish = false

Expand Down
2 changes: 2 additions & 0 deletions cspell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
"TEMP-*.md",
"mutants.out",
"mutants.out.old",
"docs/issues/open/269-review-dependency-licenses/locked-license-inventory.json",
"docs/issues/open/269-review-dependency-licenses/runtime-license-inventory.json",
"docs/issues/**/2022-vendor-and-document-maintainer-merge-workflow/github-merge.py",
"contrib/dev-tools/git/github-merge.py",
"docs/issues/**/evidence/*.html"
Expand Down
61 changes: 33 additions & 28 deletions docs/issues/open/269-review-dependency-licenses/ISSUE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ priority: p2
epic: null
github-issue: 269
spec-path: docs/issues/open/269-review-dependency-licenses/ISSUE.md
branch: "269-review-dependency-licenses"
branch: "269-first-dependency-license-review"
related-pr: null
last-updated-utc: 2026-08-28 11:10
semantic-links:
Expand All @@ -17,7 +17,11 @@ semantic-links:
- .github/workflows/testing.yaml
- contrib/dev-tools/git/hooks/pre-commit.sh
- docs/issues/closed/1925-1669-si-31-configure-cargo-deny-for-layer-boundary-enforcement.md
- docs/issues/open/269-review-dependency-licenses/evidence.md
- docs/issues/open/269-review-dependency-licenses/initial-review.md
- docs/issues/open/269-review-dependency-licenses/locked-license-inventory.json
- docs/issues/open/269-review-dependency-licenses/preliminary-assessment.md
- docs/issues/open/269-review-dependency-licenses/runtime-license-inventory.json
---

# Issue #269 - Review dependency licenses
Expand Down Expand Up @@ -119,16 +123,16 @@ policy itself, provide legal advice, or compare previous and updated

Status values: `TODO`, `IN_PROGRESS`, `BLOCKED`, `DONE`.

| ID | Status | Task | Notes / Expected Output |
| --- | ------ | ---------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------- |
| T1 | TODO | Define manual review protocol | Record the unanimous-maintainer approval process, complete dependency-graph scope, evidence standards, legal-review boundaries, and twice-yearly cadence. |
| T2 | DONE | Run preliminary technical triage | Record initial high-risk and metadata findings in [`preliminary-assessment.md`](preliminary-assessment.md); do not treat it as a legal conclusion. |
| T3 | TODO | Gather independently verified data | Produce a dated full dependency inventory from reproducible tools and authoritative package license metadata. |
| T4 | TODO | Analyze license conflicts | Record actual and potential conflicts, ambiguity, and dependencies requiring qualified legal review. |
| T5 | TODO | Record decisions and actions | Produce the initial review report, exceptions or policy decisions, and follow-up issues for unresolved work. |
| T6 | TODO | Approve review outcome | Obtain and retain unanimous active-maintainer approval of the documented review outcome. |
| T7 | TODO | Publish future-review template | Convert the initial review report into the documented template and schedule for twice-yearly use. |
| T8 | TODO | Assess automation follow-up | Decide whether established rules justify a separate future automation issue; do not add CI or hook enforcement here. |
| ID | Status | Task | Notes / Expected Output |
| --- | ----------- | ---------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| T1 | DONE | Define manual review protocol | Recorded the review protocol, evidence standards, legal-review boundaries, unanimous-approval process, cadence, and interim-review triggers in [`initial-review.md`](initial-review.md). |
| T2 | DONE | Run preliminary technical triage | Record initial high-risk and metadata findings in [`preliminary-assessment.md`](preliminary-assessment.md); do not treat it as a legal conclusion. |
| T3 | DONE | Gather independently verified data | Produced a dated locked-graph inventory and source-manifest evidence in [`evidence.md`](evidence.md). |
| T4 | IN_PROGRESS | Analyze license conflicts | Recorded material findings in [`initial-review.md`](initial-review.md); `bloom` remains blocked pending qualified legal review. |
| T5 | IN_PROGRESS | Record decisions and actions | Produced the initial blocked review report and resolved the internal metadata gap; unresolved findings need dispositions. |
| T6 | BLOCKED | Approve review outcome | Requires qualified legal disposition for `bloom`, other finding dispositions, and explicit unanimous active-maintainer approval. |
| T7 | DONE | Publish future-review template | The initial report and evidence ledger define the twice-yearly template and schedule the next review for 2027-02-28. |
| T8 | DONE | Assess automation follow-up | Deferred: no approved SPDX policy or exception process yet justifies enforcement. |

## Progress Tracking

Expand All @@ -137,11 +141,11 @@ Status values: `TODO`, `IN_PROGRESS`, `BLOCKED`, `DONE`.
- [x] Existing GitHub issue reviewed and its discussion incorporated into this spec.
- [x] Specification converted to folder layout with issue-local evidence artifacts.
- [x] Specification reviewed and approved by user/maintainer.
- [ ] Unanimous-maintainer approval process, review protocol, and scope decisions recorded.
- [ ] Spec-only PR merged into `develop` before implementation.
- [ ] Implementation completed.
- [ ] Documentation validation completed (`linter all`).
- [ ] Manual verification scenarios executed and recorded (status + evidence).
- [x] Unanimous-maintainer approval process, review protocol, and scope decisions recorded.
- [x] Spec-only PR merged into `develop` before implementation.
- [ ] Implementation completed; legal and unanimous-maintainer approval remain blocked.
- [x] Documentation validation completed (`linter all`).
- [x] Initial technical manual-review scenario executed and recorded in `evidence.md`.
- [ ] Acceptance criteria reviewed after implementation and updated with evidence.
- [ ] Reviewer validated acceptance criteria and updated checkboxes.
- [ ] Committer verified spec progress is up to date before commit.
Expand All @@ -157,6 +161,7 @@ Status values: `TODO`, `IN_PROGRESS`, `BLOCKED`, `DONE`.
- 2026-08-28 10:20 UTC - agent - Created the preliminary assessment artifact from current Cargo metadata and package manifests. It identifies the direct `bloom` GPL-2.0 dependency as requiring urgent qualified legal review and does not state a final compatibility conclusion.
- 2026-08-28 10:35 UTC - agent - Installed `cargo-license` 0.7.0 at the user's request and incorporated its production-oriented inventory into the preliminary assessment. The new inventory corroborates, but does not resolve, the GPL-2.0, LGPL-3.0, and non-routine-license findings.
- 2026-08-28 11:10 UTC - user - Approved the issue specification and preliminary assessment; authorized a spec-only PR targeting `develop`.
- 2026-08-28 - agent - Completed the first locked-graph technical inventory and evidence ledger at merged commit `c30fbff4`. The `workspace-coupling` metadata gap is resolved; `bloom` remains blocked pending qualified legal review and active-maintainer approval.

@da2ce7 da2ce7 Sep 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit — this entry omits the HH:MM UTC component that every other changelog line carries, and the frontmatter last-updated-utc still reads 2026-08-28 11:10 although this commit rewrites the task table, the manual-verification table and the acceptance table. docs/skills/semantic-skill-link-convention.md lists last-updated-utc among the required issue-spec fields.


## Acceptance Criteria

Expand Down Expand Up @@ -204,21 +209,21 @@ Define verification before implementation starts and execute it before closing t

Status values: `TODO`, `IN_PROGRESS`, `DONE`, `FAILED`, `BLOCKED`.

| ID | Scenario | Command/Steps | Expected Result | Status | Evidence |
| --- | -------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------- | -------------------------------------------------------------------------------------------------- | ------ | -------------------------------------------------------------------- |
| M1 | Initial full review | Run the documented inventory commands against the complete resolved graph; verify non-trivial metadata with the required sources; record analysis and actions. | A dated, reproducible review report is produced with evidence for every finding. | TODO | `preliminary-assessment.md` is incomplete preliminary evidence only. |
| M2 | Maintainer approval | Present the initial report and review protocol to every active maintainer using the defined approval process. | Unanimous approval or recorded unresolved objections; unresolved matters are escalated or tracked. | TODO | Pending defined approval process. |
| M3 | Recurring-review rehearsal | Use the initial report structure to plan the next review and an interim dependency-update review. | The report functions as a clear reusable template with a next-review date and triggers. | TODO | Pending initial report. |
| ID | Scenario | Command/Steps | Expected Result | Status | Evidence |
| --- | -------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------- | -------------------------------------------------------------------------------------------------- | ----------- | ------------------------------------------------------------------------------------------------------------------- |
| M1 | Initial full review | Run the documented inventory commands against the complete resolved graph; verify non-trivial metadata with the required sources; record analysis and actions. | A dated, reproducible review report is produced with evidence for every finding. | IN_PROGRESS | Technical evidence is complete; each finding needs a maintainer-approved disposition or qualified legal escalation. |
| M2 | Maintainer approval | Present the initial report and review protocol to every active maintainer using the defined approval process. | Unanimous approval or recorded unresolved objections; unresolved matters are escalated or tracked. | TODO | Pending defined approval process. |
| M3 | Recurring-review rehearsal | Use the initial report structure to plan the next review and an interim dependency-update review. | The report functions as a clear reusable template with a next-review date and triggers. | DONE | [`initial-review.md`](initial-review.md) schedules 2027-02-28 and records interim-review triggers. |

### Acceptance Verification

| AC ID | Status (`TODO`/`DONE`) | Evidence |
| ----- | ---------------------- | -------------------------------------------------------------- |
| AC1 | TODO | Pending approved review protocol. |
| AC2 | TODO | Pending initial review report. |
| AC3 | TODO | Preliminary triage: `bloom` GPL-2.0 requires qualified review. |
| AC4 | TODO | Pending recurring template. |
| AC5 | TODO | Pending automation assessment. |
| AC ID | Status (`TODO`/`DONE`) | Evidence |
| ----- | ---------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------- |
| AC1 | TODO | Protocol is documented; unanimous active-maintainer approval is pending. |
| AC2 | DONE | [`initial-review.md`](initial-review.md), [`evidence.md`](evidence.md), and the retained inventory artifacts record the locked graph and sources. |
| AC3 | TODO | Material findings are recorded; `bloom` requires qualified legal review and other dispositions remain pending. |
| AC4 | DONE | The report and ledger are the recurring template; next review is scheduled for 2027-02-28. |
| AC5 | DONE | The report defers automation because approved deterministic rules do not yet exist. |

## Risks and Trade-offs

Expand Down
Loading
Loading