test(integration): [#1419] use explicit config path fixtures - #2189
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The functional change is low-risk and aligns with #2151’s explicit-config startup flow; the only noted follow-up is a minor issue-spec metadata formatting tweak.
Pull request overview
This PR updates the main-level integration-test fixture to start the tracker using the explicit config TOML path entry point added in #2151, eliminating process-wide configuration environment mutation and its associated synchronization guard.
Changes:
- Switched
TrackerApplicationFixturestartup toapp::start_with_explicit_config_toml_path(...)using the workspace-local config file. - Removed the global environment lock and
unsafe std::envmutation/restoration guard from the shared integration workspace helper. - Updated test documentation and issue #1419 notes to reflect that base-source configuration injection via environment is no longer required for in-process fixtures.
File summaries
| File | Description |
|---|---|
| tests/common/workspace.rs | Removes process-global env mutation and starts the app using an explicit config TOML path. |
| tests/AGENTS.md | Updates test guidance to reflect explicit-path startup for in-process fixtures. |
| docs/issues/open/1419-allow-multiple-integration-tests-at-main-app-level/ISSUE.md | Updates issue narrative and acceptance-criteria notes to reflect the fixture migration away from env-based base-source injection. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2189 +/- ##
===========================================
- Coverage 84.97% 84.97% -0.01%
===========================================
Files 351 351
Lines 30211 30208 -3
Branches 30211 30208 -3
===========================================
- Hits 25672 25668 -4
Misses 4168 4168
- Partials 371 372 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
59d1493 to
ddb8a60
Compare
|
ACK 708cb81 |
be65276 docs(review): document PR 2198 Copilot audit (Jose Celano) 6bbbf72 docs(issues): format issue 1419 delivery record (Jose Celano) f1ef4aa docs(issues): record issue 1419 partial delivery (Jose Celano) Pull request description: ## Summary Records PR #2189 as the merged partial fixture-isolation delivery for issue #1419 and corrects the issue lifecycle after it was reopened. ## Updates - Sets `related-pr: 2189`. - Marks the partial-improvement PR completion step done. - Records that PR #2189 resolved only base-source environment mutation in the shared fixture. - Records the accidental GitHub closure and reopening. - Keeps the issue open with the #1488-dependent cooperative-shutdown review and final closure review still pending. ## Validation - `linter markdown` - `linter cspell` - `linter lychee` - `git diff --check` - required pre-commit gate Related to #1419 ACKs for top commit: josecelano: ACK be65276 Tree-SHA512: 4910d16f34b710f149e4bac592a20d101c9cb131a0363f07687c626645a132365236dcb0a8c96c0f4b93eabcbd6ed3b845cc9f8332bc71c23880c9ec9c0c59e5
Summary
Migrates the shared main-level integration fixture from process-wide configuration environment mutation to the explicit configuration-file startup API added by #2151.
Changes
TrackerApplicationFixturenow passes its existing isolated workspace TOML file toapp::start_with_explicit_config_toml_path.std::envmutation.tests/AGENTS.mdand issue Allow multiple integration tests at the main app level #1419 to distinguish the resolved configuration-injection constraint from the still-deferred process-global lifecycle and shutdown constraints.Validation
cargo fmt --checkpassed.Related to #1419
This PR does not close #1419. Cooperative server shutdown and the post-#1488 fixture review remain tracked there.