feat: surface cron windows in webapp, cli, sdk - #4572
Conversation
🦋 Changeset detectedLatest commit: 6a73a1a The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (17)
WalkthroughThe change adds optional duration or percentage windows to declarative schedules. Scheduling utilities calculate nominal CRON times and effective assigned times. Presenters and APIs return both timestamps and window metadata. Dashboard views and forms display and edit windows. Deployment responses and CLI output include declarative schedule details. Tests cover SDK serialization, timing calculations, API lifecycle behavior, and deployment formatting. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2ba481a to
eb8c3af
Compare
Observability mapAs of Nothing in this pull request moves the report any more. The findings an earlier push reported are gone. The score and findings here are report-only and never gate the merge. Separately, a required test suite keeps this tool's symbol and route lists in sync with the code they name, and can fail a pull request that renames or removes a symbol they reference, or that adds the first route with a segment they anticipate. Each failure names the list to edit. The rules and their reasons: internal-packages/observability-map/README.md. |
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
eb8c3af to
9ecb63f
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
6bd63af to
75080c1
Compare
206ef69 to
1ecb593
Compare
8058d83 to
c6f4c34
Compare
Summary
Adds execution-window product surfaces for both declarative and imperative schedules.
windowthroughschedules.task(), with support for whole-minute, hour, and percentage values.nextRunas the nominal CRON time and exposenextRunEffectiveAtas the stable assigned time.Design
Window validation remains authoritative on the server and ensures each window is compatible with the schedule cadence. Omitting a window uses the default 60-second range, while explicit zero-duration windows remain supported.
Deployment summaries are derived from the deployment's stored task metadata, so they reflect the declarations associated with that deployment.