Skip to content

feat(base-images): immutable per-publish image tags - #4607

Merged
myftija merged 3 commits into
mainfrom
dated-base-image-tags
Aug 13, 2026
Merged

feat(base-images): immutable per-publish image tags#4607
myftija merged 3 commits into
mainfrom
dated-base-image-tags

Conversation

@myftija

@myftija myftija commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Every publish now also pushes an immutable per-publish tag alongside the mutable one, named after the snapshot date and commit (e.g. 22-bookworm-20260812-45444a7), so previously published digests stay tag-referenced after republishes. Shipped CLI releases pin those digests, so they must remain resolvable indefinitely.

Merging triggers a republish; the fresh tag-protected digests will then be pinned by #4602 before it merges.

Mutable tags move on every republish, leaving previously published
digests untagged and exposed to any future untagged-manifest cleanup,
while shipped CLI releases pin those digests. A dated tag per publish
keeps every digest tag-referenced permanently and doubles as a durable
record of what was published when.
Two same-day publishes share a snapshot timestamp, so a date-only tag
would be overwritten and orphan the first publish's digests; snapshot
date plus commit matches exactly what determines the digests, and a
re-run of the same commit re-tags the identical digest.
@changeset-bot

changeset-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ed9f3da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1cb281bd-69f8-43a4-8192-17f0d1257b1a

📥 Commits

Reviewing files that changed from the base of the PR and between 8bcb764 and ed9f3da.

📒 Files selected for processing (2)
  • .github/workflows/base-images.yml
  • base-images/README.md
🚧 Files skipped from review as they are similar to previous changes (2)
  • base-images/README.md
  • .github/workflows/base-images.yml
📜 Recent review details
⏰ Context from checks skipped due to timeout. (8)
  • GitHub Check: publish (node, 26-bookworm, node:26.4.0-bookworm-slim@sha256:ec82d089a8ae2cf02628da7b34ea57dc357b...
  • GitHub Check: publish (node, 24-bookworm, node:24.18.0-bookworm-slim@sha256:6f7b03f7c2c8e2e784dcf9295400527b9b1...
  • GitHub Check: publish (node, 21-bookworm, node:21.7.3-bookworm-slim@sha256:dfc05dee209a1d7adf2ef189bd97396daad4...
  • GitHub Check: publish (node, 22-bookworm, node:22.16.0-bookworm-slim@sha256:048ed02c5fd52e86fda6fbd2f6a76cf0d44...
  • GitHub Check: publish (bun, 1.3-node20-bookworm, imbios/bun-node:1.3.3-20-slim@sha256:59d84856a7e31eec83afedadb...
  • GitHub Check: code-quality / code-quality
  • GitHub Check: audit
  • GitHub Check: Analyze (javascript-typescript)

Walkthrough

The setup job generates a publish ID from the Debian snapshot date and short commit SHA. The workflow exports this ID and adds immutable snapshot-specific tags to runtime and build images while retaining mutable tags. The README documents the tag format, retention requirement, and use by digest-pinned CLI releases.

Mergeability Score: ⚪ Minimal · up to ed9f3

The change adds immutable per-publish image tags to preserve digest references, and no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change and its purpose but omits the required issue, checklist, testing, changelog, and screenshots sections. Add the required template sections, complete the checklist, document testing steps, provide the changelog entry, and include screenshots or state that they are not applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding immutable per-publish image tags.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dated-base-image-tags

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]

This comment was marked as resolved.

The snapshot timestamp, not just its date, determines the published
digests; a same-commit dispatch with an intra-day snapshot time could
otherwise overwrite the tag and orphan the earlier digests.
devin-ai-integration[bot]

This comment was marked as resolved.

@myftija
myftija merged commit 035e710 into main Aug 13, 2026
36 checks passed
@myftija
myftija deleted the dated-base-image-tags branch August 13, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants