Skip to content

fix(webapp): use native checkbox label semantics - #4697

Merged
carderne merged 2 commits into
fix/webapp-control-labels-tri-13381from
fix/webapp-checkbox-semantics-tri-13381
Aug 19, 2026
Merged

fix(webapp): use native checkbox label semantics#4697
carderne merged 2 commits into
fix/webapp-control-labels-tri-13381from
fix/webapp-checkbox-semantics-tri-13381

Conversation

@carderne

@carderne carderne commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Use native label and checkbox behavior for CheckboxWithLabel and enforce jsx-a11y/no-noninteractive-element-interactions.

The component no longer simulates checkbox activation with click handlers on non-interactive wrappers. Native change events now drive the controlled checked state.

Base: #4696

@changeset-bot

changeset-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 098f636

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 19cfbc88-e3da-44a6-9a63-7b49a240df2a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@carderne
carderne marked this pull request as ready for review August 19, 2026 11:23
devin-ai-integration[bot]

This comment was marked as resolved.

@carderne
carderne force-pushed the fix/webapp-checkbox-semantics-tri-13381 branch from b69c00e to ed33b99 Compare August 19, 2026 11:48
@carderne
carderne force-pushed the fix/webapp-checkbox-semantics-tri-13381 branch from ed33b99 to f436aa1 Compare August 19, 2026 11:49
@carderne
carderne force-pushed the fix/webapp-checkbox-semantics-tri-13381 branch from ea472f1 to 098f636 Compare August 19, 2026 14:54
@pkg-pr-new

pkg-pr-new Bot commented Aug 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@098f636

trigger.dev

npm i https://pkg.pr.new/trigger.dev@098f636

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@098f636

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@098f636

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@098f636

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@098f636

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@098f636

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@098f636

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@098f636

commit: 098f636

@carderne
carderne merged commit 3d156df into main Aug 19, 2026
39 checks passed
@carderne
carderne deleted the fix/webapp-checkbox-semantics-tri-13381 branch August 19, 2026 15:36
carderne added a commit that referenced this pull request Aug 19, 2026
## Summary

Replace mouse-only dashboard actions with native buttons.

Copy, remove, and stop-generation controls now expose keyboard focus and
accessible names. Hover-revealed actions remain mounted so keyboard
users can discover them, and a decorative clipboard icon no longer
captures clicks.

Base: [#4697](#4697)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants