Skip to content

Toggle switch feels nicer to toggle #4749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samejr merged 2 commits into from
Aug 21, 2026
+16 −7
Merged

Toggle switch feels nicer to toggle #4749

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a49e2f2
feat(webapp): squish the toggle switch thumb while it's held down
samejr Aug 21, 2026
dcda5ff
chore(webapp): drop the comment from the Switch thumb
samejr Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions apps/webapp/app/components/primitives/Switch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,22 @@ import { type ShortcutDefinition, useShortcutKeys } from "~/hooks/useShortcutKey
const small = {
container:
"flex items-center h-6 gap-x-1.5 rounded hover:bg-tertiary pr-1 py-[0.1rem] pl-1.5 hover:disabled:bg-background-raised transition focus-custom disabled:opacity-50 text-text-dimmed hover:text-text-bright disabled:hover:cursor-not-allowed hover:cursor-pointer disabled:hover:text-rose-500",
root: "h-3 w-6",
thumb: "size-2.5 data-[state=checked]:translate-x-2.5 data-[state=unchecked]:translate-x-0",
root: "h-3 w-5.5",
thumb: cn(
"h-2.5 w-2.5 data-[state=checked]:translate-x-2 data-[state=unchecked]:translate-x-0",
"group-active:w-3.25 group-active:data-[state=checked]:translate-x-1.25"
Comment thread
coderabbitai[bot] marked this conversation as resolved.
),
text: "text-xs text-text-dimmed",
};

const variations = {
large: {
container: "flex items-center gap-x-2 rounded-md hover:bg-tertiary p-2 transition focus-custom",
root: "h-6 w-11",
thumb: "size-5 data-[state=checked]:translate-x-5 data-[state=unchecked]:translate-x-0",
root: "h-6 w-10.5",
thumb: cn(
"h-5 w-5 data-[state=checked]:translate-x-4.5 data-[state=unchecked]:translate-x-0",
"group-active:w-6.5 group-active:data-[state=checked]:translate-x-3"
),
text: "text-sm text-text-dimmed",
},
small,
Expand Down Expand Up @@ -48,8 +54,11 @@ const variations = {
medium: {
container:
"flex items-center gap-x-2 rounded-md hover:bg-tertiary py-1.5 px-2 transition focus-custom",
root: "h-4 w-8",
thumb: "size-3.5 data-[state=checked]:translate-x-3.5 data-[state=unchecked]:translate-x-0",
root: "h-4 w-7.5",
thumb: cn(
"h-3.5 w-3.5 data-[state=checked]:translate-x-3 data-[state=unchecked]:translate-x-0",
"group-active:w-4.5 group-active:data-[state=checked]:translate-x-2"
),
text: "text-sm text-text-dimmed",
},
};
Expand Down Expand Up @@ -96,7 +105,7 @@ export const Switch = React.forwardRef<React.ElementRef<typeof SwitchPrimitives.
<SwitchPrimitives.Thumb
className={cn(
thumb,
"pointer-events-none block rounded-full bg-white transition dark:bg-charcoal-200 dark:group-data-[state=checked]:bg-text-bright"
"pointer-events-none block rounded-full bg-white transition-[translate,width,background-color] dark:bg-charcoal-200 dark:group-data-[state=checked]:bg-text-bright"
)}
/>
</div>
Expand Down