Hand graceful_shutdown()'s cancellation to the coroutines (#302) - #304
Merged
Merged
Conversation
The PHP function parsed $cancellationError and then called
ZEND_ASYNC_SHUTDOWN(), which takes nothing, so cancel_queued_coroutines()
always built its own AsyncCancellation("Graceful shutdown").
start_graceful_shutdown_with(cancellation) carries the object into the
scheduler; NULL keeps the default, and the API entry point
start_graceful_shutdown() wraps it, so the ABI is unchanged. The second
cancellation pass in finally_shutdown() stays on the default.
Test: tests/edge_cases/015-graceful_shutdown_custom_cancellation.phpt,
red without the change. ext/async/tests 1220 passed, fuzzy-tests/_generated
724 passed.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #302.
graceful_shutdown($cancellationError)parsed the argument and then calledZEND_ASYNC_SHUTDOWN(), which takes nothing, socancel_queued_coroutines()always built its ownAsyncCancellation("Graceful shutdown").start_graceful_shutdown_with(cancellation)carries the object into the scheduler; NULL keeps the default, and the API entry pointstart_graceful_shutdown()wraps it, so the ABI is unchanged. A shutdown already in progress keeps its own cancellation. The second cancellation pass infinally_shutdown()stays on the default.Test:
tests/edge_cases/015-graceful_shutdown_custom_cancellation.phpt, red without the change. Local run:ext/async/tests1220 passed / 0 failed,fuzzy-tests/_generated724 / 0.