Preserve QFN thermal vias during CLI footprint imports - #4270
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
| ) | ||
| const manifoldWasm = Bun.file(manifoldWasmSourcePath) | ||
| await Bun.write("./dist/cli/manifold.wasm", manifoldWasm) | ||
|
|
There was a problem hiding this comment.
circuit-json-to-footprinter@0.0.46 introduces @tscircuit/manifold-2d for footprint geometry operations.
The CLI bundles this dependency into dist/cli/main.js. In Node.js, Manifold loads manifold.wasm relative to that bundled JS file, but Bun does not automatically copy the WASM asset into dist.
As a result, the globally installed CLI crashed during startup because it expected:
dist/cli/manifold.wasm
Copying the package-exported WASM file next to main.js preserves Manifold's runtime loading contract. Only dist/cli needs the asset because the other generated bundles do not include the Manifold loader.
There was a problem hiding this comment.
i don't think this is necessary
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
|
sctive |
imrishabh18
left a comment
imrishabh18
left a comment
There was a problem hiding this comment.
I am not sure, get a review from Seve
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
looks like some crazy manifold hack was introduced, afaik you don't need this hack
|
Yes but the built CLI demonstrably crashes without it |
3 participants
No description provided.