Skip to content

fix: recognize prebuilt circuit json by content - #4303

Closed
ShiboSoftwareDev wants to merge 1 commit into
repro/prebuilt-json-content-recognitionfrom
fix/prebuilt-json-content-recognition
Closed

fix: recognize prebuilt circuit json by content#4303
ShiboSoftwareDev wants to merge 1 commit into
repro/prebuilt-json-content-recognitionfrom
fix/prebuilt-json-content-recognition

Conversation

@ShiboSoftwareDev

Copy link
Copy Markdown
Contributor

Summary

  • recognize prebuilt Circuit JSON from a discriminated element array instead of requiring a special filename suffix
  • preserve the existing canonical filename fallback for backward compatibility
  • run check shorts successfully against shorted-board.json and render its PCB debug snapshot

Stack

Verification

  • bun test tests/cli/check/check-shorts.test.ts (7 pass)
  • bun test tests/cli/check (26 pass when run with localhost fixture access)
  • bun run build
  • bunx biome format cli/check/shared.ts tests/cli/check/check-shorts.test.ts
  • fixed PCB SVG snapshot rendered and visually inspected

@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

@github-actions

Copy link
Copy Markdown
Contributor

This PR was closed because it has been inactive for 1 day since being marked as stale.

@github-actions github-actions Bot closed this Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant