Improve compile-time machine diagnostics - #16
Merged
Conversation
SandroMaglione
marked this pull request as ready for review
August 2, 2026 12:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eventsorinternalEventsinstead of surfacing them through a validation rest parameterWhy
State, event, and handler validation previously collapsed failures into rest-parameter or root-level intersections. TypeScript consequently reported errors such as
Expected 2 argumentsor printed the complete machine or handler definition without identifying the configuration entry responsible for the failure.The new validation overlays retain the authored object shape and use
NoInferso validation does not participate in configuration inference.Type performance
Measured with TypeScript 6.0.3 and
skipLibCheck=true.Machine.defineStatesMachine.makemachine.handleMarginal instantiations, measured against the matching setup without the API call:
Machine.defineStatesMachine.makemachine.handleThe richer per-node handler diagnostics add 593 total instantiations in the representative handle scenario, while the refactored make validation removes 517 instantiations.
Validation
pnpm checkpnpm perf:types