Feature/dtc select all modules - #206
Merged
Merged
Conversation
Picking DTC modules to scan or clear previously required checking each module individually. The picker dialog now has a neutral button that selects or deselects every module at once (label reflects current state), disables the confirm button when nothing is selected, and shows a distinct title depending on whether it was opened from the Refresh or Clear action. Also bumps obdMetricVersion to 11.26.1-SNAPSHOT to pick up the multi-module DTC equality fix from obd-metrics. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…r flow
The module picker's confirm button always read "Scan" regardless of
which action opened it, so clearing DTCs showed a "Scan" button that
didn't actually scan or clear anything - the real clear confirmation
comes up in a follow-on dialog. The button label is now passed in
per-flow ("Scan" for Refresh, "Continue" for Clear).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…out, add Scan description The Clear-DTC flow required accepting two separate dialogs in a row (module picker, then a plain confirmation dialog). Both are now folded into a single dialog: the picker's custom view carries the warning message above the checklist, and its confirm button performs the clear directly. A plain AlertDialog can't combine setMessage() with setMultiChoiceItems() (the platform only wires in the list when no message is set), so the dialog's content is now a custom view, and the three action buttons are laid out in a manual horizontal LinearLayout instead of the platform's button bar, which was auto-stacking them vertically once their combined text no longer fit on one line. Also: - The confirm button (Scan / Clear Codes) uses the project's rainbow_indigo accent color, dimming via ColorStateList when disabled (no modules selected) rather than staying falsely bright. - The Scan dialog now shows a short description above its checklist, mirroring the Clear dialog's warning. - Added confirmWhenEmpty so only the destructive Clear flow forces a dialog when no DRI modules are configured; Scan keeps skipping straight through to avoid an empty, pointless dialog for the common single-ECU case. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.