feat(pid-picker): dim window scrim, style category headers, fix grouping - #210
Merged
Merged
Conversation
tzebrowski
commented
Aug 16, 2026
tzebrowski
commented
Owner
- Dialog window background: theme-aware translucent scrim (dialog_scrim color) instead of fully transparent, so Settings screen no longer bleeds through behind the picker.
- Category header rows in the list now use the same green pill style as the active vertical index-bar marker, instead of plain text.
- "Selected" header checkbox switched from GONE to INVISIBLE so its indent matches the other category headers.
- category_selected checkbox given an explicit theme-aware tint (previously washed out/near-invisible in light theme).
- PID category grouping (PidCategory.kt) overhaul:
- normalize newlines in PID descriptions before keyword matching (fixes "Measured Intake\nPressure" not matching "intake pressure")
- add Knock/Coil/Injection keywords to Ignition
- add Throttle position/angle keywords to Boost
- new IBS category (renamed from IAM) for IAM:/IBS PIDs
- new Oil category, split out of Electrical/Temperature/Other
- remove Electrical (down to one item), fold voltage/battery into IBS
- Dialog window background: theme-aware translucent scrim (dialog_scrim
color) instead of fully transparent, so Settings screen no longer
bleeds through behind the picker.
- Category header rows in the list now use the same green pill style as
the active vertical index-bar marker, instead of plain text.
- "Selected" header checkbox switched from GONE to INVISIBLE so its
indent matches the other category headers.
- category_selected checkbox given an explicit theme-aware tint
(previously washed out/near-invisible in light theme).
- PID category grouping (PidCategory.kt) overhaul:
- normalize newlines in PID descriptions before keyword matching
(fixes "Measured Intake\nPressure" not matching "intake pressure")
- add Knock/Coil/Injection keywords to Ignition
- add Throttle position/angle keywords to Boost
- new IBS category (renamed from IAM) for IAM:/IBS PIDs
- new Oil category, split out of Electrical/Temperature/Other
- remove Electrical (down to one item), fold voltage/battery into IBS
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Lint (MissingTranslation) failed the build because the new category_ibs and category_oil strings had no values-pl entries. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.