fix: use PidDefinition.category for locale-independent PID grouping - #211
Merged
Conversation
PidCategory.categoryFor() matched English keywords against description/longDescription, which broke under non-English locales since the translation provider overwrites that text in place -- most PIDs fell through to "Other". Prefer the new upstream category tag (untranslated, stable regardless of active language) and only fall back to text matching for PIDs the tag doesn't cover yet (custom PIDs, or new upstream PIDs added before regeneration). Requires obd-metrics 11.26.1-SNAPSHOT. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PidCategory.categoryFor() matched English keywords against description/longDescription, which broke under non-English locales since the translation provider overwrites that text in place -- most PIDs fell through to "Other". Prefer the new upstream category tag (untranslated, stable regardless of active language) and only fall back to text matching for PIDs the tag doesn't cover yet (custom PIDs, or new upstream PIDs added before regeneration). Requires obd-metrics 11.26.1-SNAPSHOT.