fix: don't reset chart zoom when toggling signal visibility - #189
Merged
Conversation
buildDataset() and the legend labels.filter callback both read appState.isSignalVisible() (backed by the hiddenSignalKeys signal) synchronously during Chart.js construction inside the chart-view effect that rebuilds (destroy + new Chart) on structural changes. Since Angular effects track every signal read during their synchronous execution -- including reads from nested calls -- this made the rebuild effect implicitly depend on hiddenSignalKeys too, so simply checking another signal in the sidebar list destroyed and recreated every chart, discarding zoom/pan state. Wrap both reads in untracked() so visibility toggles are only handled by the dedicated hiddenSignalKeys effect (syncVisibility), which already updates existing datasets in place. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildDataset() and the legend labels.filter callback both read appState.isSignalVisible() (backed by the hiddenSignalKeys signal) synchronously during Chart.js construction inside the chart-view effect that rebuilds (destroy + new Chart) on structural changes. Since Angular effects track every signal read during their synchronous execution -- including reads from nested calls -- this made the rebuild effect implicitly depend on hiddenSignalKeys too, so simply checking another signal in the sidebar list destroyed and recreated every chart, discarding zoom/pan state. Wrap both reads in untracked() so visibility toggles are only handled by the dedicated hiddenSignalKeys effect (syncVisibility), which already updates existing datasets in place.