feat: group sidebar signals by category, matching AutoTuner's Measure… - #190
Merged
Conversation
…s panel Adds a keyword-based categorizer (Basics/Ignition/Fuel-AFR/Boost/ Load-Torque/Temperature/Air-Intake/Electrical/Location/Other) since no upstream source -- the ObdMetrics registry, SignalRegistryService, or the loaded file itself -- carries a category for a signal. The sidebar's "Log Data" bucket now renders as collapsible category groups, each with a tri-state header checkbox (toggles every signal in that group via the existing setAllSignalsVisibleForFile) plus per-signal checkboxes and color swatches underneath, unchanged from before. Math Channels stay in their own flat bucket. Chart colors are unaffected since they're derived from each signal's index in availableSignals, not its position in the sidebar list. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
O2 sensor voltage is an AFR/emissions reading, not a generic electrical one -- it was falling through to Electrical purely because it contains "voltage". Calculated horsepower wasn't matching any rule at all and fell to Other, despite being derived directly from torque. Found while checking the bundled sample-trip-giulia.json, whose signal names (Air Fuel Ratio, O2 Voltage, Calculated horse power, ...) differ from the MyGiulia device-exported names the original rules were tuned against. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Raw log names (Drive uploads, and CSV re-exports chained on top of them) run 40+ characters and wrapped mid-word across two lines in the sidebar's file header. Truncate with an ellipsis instead and expose the full name as a hover tooltip. Also stop exportDataRange() from compounding the problem: it used to append a raw epoch-ms suffix directly onto the existing (already long) file name, e.g. "..._export_1786693704457.csv". Strip the noisy source extension first and name the export by its relative time range instead (matching the "Time (s)" column the CSV itself uses), e.g. "..._120s-180s.csv". Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
AutoTuner docks its "Measures" panel to the chart's right side rather than a persistent left sidebar. Adds RightSignalsPanel: a slim always-present strip along the right viewport edge that reveals a sliding panel on hover, hidden again on mouseleave. Desktop-only (hover doesn't exist on touch) -- hidden under the existing 768px breakpoint, where the left sidebar already covers this. Factored the search + category-grouped signal list itself out of Sidebar into a new SignalListPanel, shared by both the left sidebar and this new right panel so the grouping logic and markup aren't duplicated. Both instances read/write the same AppStateService, so toggling a signal on one side is instantly reflected on the other; an `idPrefix` input keeps their checkbox id/for pairs from colliding since both can be mounted at once. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s panel
Adds a keyword-based categorizer (Basics/Ignition/Fuel-AFR/Boost/ Load-Torque/Temperature/Air-Intake/Electrical/Location/Other) since no upstream source -- the ObdMetrics registry, SignalRegistryService, or the loaded file itself -- carries a category for a signal. The sidebar's "Log Data" bucket now renders as collapsible category groups, each with a tri-state header checkbox (toggles every signal in that group via the existing setAllSignalsVisibleForFile) plus per-signal checkboxes and color swatches underneath, unchanged from before. Math Channels stay in their own flat bucket. Chart colors are unaffected since they're derived from each signal's index in availableSignals, not its position in the sidebar list.