fix: make sidebar Signals section header collapsible - #191
Merged
Conversation
The "Signals" title lives inside SignalListPanel (shared with the
right-edge flyout), so it was never wired to Sidebar's
toggleSection('signals') and clicking it did nothing. Even once wired,
the generic .control-group collapse CSS would have hidden the whole
<app-signal-list-panel> element, title included, with no way back.
SignalListPanel now takes a collapsed input and emits titleClick so
Sidebar can drive the toggle while the panel hides its own body.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Signals" title lives inside SignalListPanel (shared with the right-edge flyout), so it was never wired to Sidebar's toggleSection('signals') and clicking it did nothing. Even once wired, the generic .control-group collapse CSS would have hidden the whole element, title included, with no way back. SignalListPanel now takes a collapsed input and emits titleClick so Sidebar can drive the toggle while the panel hides its own body.