fix: recover from expired Drive sessions instead of silently going stale - #192
Merged
Conversation
DriveService.findFolderId() swallowed every API error, including 401/403, and reported an expired token as "Required Drive folders not found" -- so AuthService.signOut() never fired, isLoggedIn stayed true, and the only way to refresh was a manual logout/login. Real errors now propagate to listFiles(), which first tries AuthService.silentRefresh() (a popup-free token refresh) and retries once before giving up, so routine hourly token expiry recovers invisibly. Only if that fails does it sign out of both AuthService (Drive) and AccountService (My Giulia account/top-nav) together, so the UI doesn't keep showing the user as signed in with an empty file list. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DriveService.findFolderId() swallowed every API error, including 401/403, and reported an expired token as "Required Drive folders not found" -- so AuthService.signOut() never fired, isLoggedIn stayed true, and the only way to refresh was a manual logout/login.
Real errors now propagate to listFiles(), which first tries AuthService.silentRefresh() (a popup-free token refresh) and retries once before giving up, so routine hourly token expiry recovers invisibly. Only if that fails does it sign out of both AuthService (Drive) and AccountService (My Giulia account/top-nav) together, so the UI doesn't keep showing the user as signed in with an empty file list.