Skip to content

feat(stovepipe): define configurable admission gates - #714

Draft
mnoah1 wants to merge 5 commits into
mnoah1/stovepipe-admission-throttlefrom
mnoah1/stovepipe-admission-config-v2
Draft

feat(stovepipe): define configurable admission gates#714
mnoah1 wants to merge 5 commits into
mnoah1/stovepipe-admission-throttlefrom
mnoah1/stovepipe-admission-config-v2

Conversation

@mnoah1

@mnoah1 mnoah1 commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Intent:

  • Establish an extensible framework for queue-scoped logical admission policies before controller and persistence integration.
  • Make the existing logical admission settings configurable per Stovepipe queue.

Changes:

  • Add an RFC covering gate semantics, opaque versioned state, independent outcome reconciliation, atomic policy composition, rollout, and future admission boundaries.
  • Add the vendor-neutral admissiongate contract, a request-based Gates.For resolver, decision primitives, generated mocks, and Bazel targets.
  • Add a strict YAML-backed queue configuration store and wire optional per-queue configuration into the Stovepipe service.
  • Keep storage schema changes and process/buildsignal integration for the next PR.

Test Plan

  • ./tool/bazel build //stovepipe/extension/admissiongate/...
  • make lint
  • make check-gazelle
  • make check-tidy

Revert Plan

Revert this PR to remove the admission-gate contract and RFC and restore built-in-only queue configuration.

Issues

This was referenced Sep 15, 2026
Draft
Open
Open
@mnoah1
mnoah1 added this pull request to stack #715 September 15, 2026 21:03
@mnoah1
mnoah1 marked this pull request as ready for review September 15, 2026 21:04
@mnoah1
mnoah1 requested review from a team, behinddwalls and sbalabanov as code owners September 15, 2026 21:04
@mnoah1
mnoah1 marked this pull request as draft September 15, 2026 21:04
@mnoah1
mnoah1 marked this pull request as ready for review September 15, 2026 21:04
@mnoah1
feat(stovepipe): configure admission policies per queue
c6cb600 
Summary:
Intent:
- Make logical admission throttling configurable per Stovepipe queue.

Changes:
- Add a strict, validated YAML-backed queue configuration store.
- Wire optional QUEUE_CONFIG_PATH loading into the Stovepipe server and local stack.
- Validate configured queues against message-queue tenants and document duration settings.

This change builds on the general admission throttle introduced by the parent PR.
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-admission-config-v2 branch from aa3aa8b to c6cb600 Compare September 15, 2026 21:10
@mnoah1
mnoah1 marked this pull request as draft September 15, 2026 21:10
@mnoah1 mnoah1 changed the title feat(stovepipe): configure admission policies per queue feat(stovepipe): per-queue config yaml Sep 15, 2026
@mnoah1
mnoah1 marked this pull request as ready for review September 15, 2026 21:15
@mnoah1
mnoah1 removed this pull request from stack #715 September 15, 2026 21:20
@mnoah1
mnoah1 added this pull request to stack #716 September 15, 2026 21:21
@mnoah1
mnoah1 marked this pull request as draft September 15, 2026 21:26
@mnoah1
mnoah1 marked this pull request as ready for review September 15, 2026 21:45
@mnoah1 mnoah1 changed the title feat(stovepipe): per-queue config yaml feat(stovepipe): define configurable admission gates Sep 17, 2026
@mnoah1
mnoah1 marked this pull request as draft September 17, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@behinddwalls behinddwalls Awaiting requested review from behinddwalls behinddwalls is a code owner
@sbalabanov sbalabanov Awaiting requested review from sbalabanov sbalabanov is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mnoah1