Conversation
Summary: Intent: - Prevent permanent promotion failures from occupying the record DLQ indefinitely. - Preserve successful validation state while making abandoned promotion visible in request history. Changes: - Add record-specific DLQ handling that does not repeat known promotion failures. - Retain an idempotent promotion_failed history event before acknowledging abandoned promotion work. - Keep non-promotion reconciliation under the existing DLQ retry policy. --- <sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Intent:
Changes:
record_failedhistory event.record_stage=promotionrather than as a separate event type.Generated by the 🪄 pr-create skill in devexp-agent-marketplace
Test Plan
go test ./stovepipe/entity ./stovepipe/core/requestlog ./stovepipe/controller/record ./service/stovepipe/server./tool/bazel test //stovepipe/entity:go_default_test //stovepipe/core/requestlog:go_default_test //stovepipe/controller/record:go_default_test //service/stovepipe/server:go_default_test --test_output=errorsmake lintmake check-tidymake check-gazelleIssues