Conversation
louis-z
force-pushed
the
docker-dotnet-testcontainers-migration
branch
from
September 17, 2026 13:47
fcae0b9 to
94c0f83
Compare
louis-z
marked this pull request as ready for review
September 17, 2026 15:07
louis-z
marked this pull request as draft
September 17, 2026 17:05
louis-z
marked this pull request as ready for review
September 17, 2026 17:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker.DotNetpackage (unmaintained) withDocker.DotNet.Enhanced(its actively maintained fork, now owned by the Testcontainers org).Testcontainerspackage.GitLabDockerContainer.SpawnLocalDockerContainerAsync(used for local test runs) now creates/starts the GitLab container via Testcontainers'ContainerBuilder, instead of ~90 lines of manual container lookup/create/start/health-polling code.RunGitLabRailsRunnerAsync) now runs thegitlab-rails runnercommand differently depending on how the container came to exist:Docker.DotNet.Enhanced) to find that container and exec into it.Rationale
Docker.DotNethas had no releases or fixes in a long time; staying on it was a growing maintenance risk.Testcontainersis the purpose-built library for "spin up a container for tests, wait until it's ready, tear it down"; it replaces our hand-rolled orchestration/health-check code instead of just swapping the underlying HTTP client.Docker.DotNet.Enhancedfills that one remaining need, and since Testcontainers depends on it internally too, there's no duplicate/conflicting dependency.Trade-off to know about
WithReuse(true)to keep the container running across local test runs (GitLab takes minutes to boot), but reuse matching is based on name + config.LocalGitLabDockerVersion, you now need to manually remove the old container first: