Skip to content

fix(policy): fix mininav link - #337

Merged
bniedzie merged 1 commit into
mainfrom
fix/policy-change-mininav-link
Sep 4, 2026
Merged

fix(policy): fix mininav link#337
bniedzie merged 1 commit into
mainfrom
fix/policy-change-mininav-link

Conversation

@bniedzie

@bniedzie bniedzie commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Previously, the mininav and top nav links for Policy differed on pages like RAPS 2.0, with the top nav pointing at VIPER 2.0 but the mininav pointing at VIPER 1.0.

This changes the mininav to point at 2.0, matching the behavior for Personnel.

LayoutController.cs, which impacts some pages' mininav, was already correct.

@codecov-commenter

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@codecov-commenter

codecov-commenter commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.88%. Comparing base (9975f1a) to head (048af16).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #337   +/-   ##
=======================================
  Coverage   44.88%   44.88%           
=======================================
  Files         940      940           
  Lines       49107    49107           
  Branches     6577     6577           
=======================================
  Hits        22041    22041           
  Misses      26128    26128           
  Partials      938      938           
Flag Coverage Δ
backend 42.13% <ø> (ø)
frontend 63.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
web/Views/Shared/Components/MiniNav/Default.cshtml 0.00% <ø> (ø)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a small, consistent link update to an already-established VIPER 2.0 route and does not introduce new logic or risk-prone behavior.

Pull request overview

Aligns the MiniNav “Policies” link with the existing top navigation behavior so both point to the VIPER 2.0 Policy page (instead of MiniNav sending users to the legacy VIPER 1.0 Policy page).

Changes:

  • Update MiniNav “Policies” to use the app-relative VIPER 2.0 route (~/Policy) rather than OldViperURL + /policy/default.cfm.
File summaries
File Description
web/Views/Shared/Components/MiniNav/Default.cshtml Updates the MiniNav Policies link target to VIPER 2.0 (~/Policy) to match the top nav behavior.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@bniedzie
bniedzie merged commit e8767b2 into main Sep 4, 2026
14 of 15 checks passed
@bniedzie
bniedzie deleted the fix/policy-change-mininav-link branch September 4, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants