Skip to content

Skip /config/dump pre-flight for md/llm endpoints in playground #2224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SohamKukreti wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Skip /config/dump pre-flight for md/llm endpoints in playground #2224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 24 additions & 22 deletions deploy/docker/static/playground/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,29 +686,31 @@ <h2 class="font-medium text-accent">🔥 Stress Test</h2>
async function runCrawl() {
const endpoint = document.getElementById('endpoint').value;
const urls = document.getElementById('urls').value.trim().split(/\n/).filter(u => u);
// 1) grab python from CodeMirror, validate via /config/dump
// 1) grab python from CodeMirror, validate via /config/dump.
// Advanced Config is /crawl-only, so md/llm skip this entirely.
let advConfig = {};
try {
const cfgJson = await pyConfigToJson(); // may throw
if (Object.keys(cfgJson).length) {
const cfgType = document.getElementById('cfg-type').value;
advConfig = cfgType === 'CrawlerRunConfig'
? { crawler_config: cfgJson }
: { browser_config: cfgJson };
}
} catch (err) {
const codeText = cm.getValue();
const streamFlag = /stream\s*=\s*True/i.test(codeText);
const isCrawlEndpoint = document.getElementById('endpoint').value === 'crawl';
if (isCrawlEndpoint && streamFlag) {
// Fallback: minimal dump-shaped config so shouldUseStream + server load agree
advConfig = { crawler_config: { type: 'CrawlerRunConfig', params: { stream: true } } };
} else {
updateStatus('error');
document.querySelector('#response-content code').textContent =
JSON.stringify({ error: err.message }, null, 2);
forceHighlightElement(document.querySelector('#response-content code'));
return; // stop run
if (endpoint === 'crawl' || endpoint === 'crawl_stream') {
try {
const cfgJson = await pyConfigToJson(); // may throw
if (Object.keys(cfgJson).length) {
const cfgType = document.getElementById('cfg-type').value;
advConfig = cfgType === 'CrawlerRunConfig'
? { crawler_config: cfgJson }
: { browser_config: cfgJson };
}
} catch (err) {
const codeText = cm.getValue();
const streamFlag = /stream\s*=\s*True/i.test(codeText);
if (streamFlag) {
// Fallback: minimal dump-shaped config so shouldUseStream + server load agree
advConfig = { crawler_config: { type: 'CrawlerRunConfig', params: { stream: true } } };
} else {
updateStatus('error');
document.querySelector('#response-content code').textContent =
JSON.stringify({ error: err.message }, null, 2);
forceHighlightElement(document.querySelector('#response-content code'));
return; // stop run
}
}
}

Expand Down
Loading