fix: use None defaults for boolean base_config fields - #2227
Open
dajiaohuang wants to merge 1 commit into
Open
Conversation
Fixes unclecode#2121 - Boolean values in crawler.base_config (like simulate_user, magic, override_navigator, check_robots_txt, remove_overlay_elements) were silently ignored because their dataclass defaults of False caused the guard check to fail. When the client doesn't send a field, it gets the dataclass default. The check 'current_value is None or current_value == ""' failed for False because False is neither None nor "". Solution: Change defaults from False to None for these fields. Now None means 'not set by client' and False means 'explicitly set to False'. The check in api.py is simplified to 'if current_value is None'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2121 - Boolean values in crawler.base_config (like simulate_user, magic, override_navigator, check_robots_txt, remove_overlay_elements) were silently ignored because their dataclass defaults of False caused the guard check to fail.
Problem
When the client doesn't send a field, it gets the dataclass default. The check 'current_value is None or current_value == ""' failed for False because False is neither None nor "".
Solution
Change defaults from False to None for these fields in CrawlerRunConfig. Now None means 'not set by client' and False means 'explicitly set to False'. The check in api.py is simplified to 'if current_value is None'.
Files changed